Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability for Maps to cast to another case where the field names are different #5703

Merged
merged 6 commits into from
Jun 22, 2024
Merged

Add the ability for Maps to cast to another case where the field names are different #5703

merged 6 commits into from
Jun 22, 2024

Commits on Jun 21, 2024

  1. Add the ability for Maps to cast to another case where the field name… 

    …s are different.

Arrow Maps have field names for the elements of the fields, the field names are allowed to be any value and do not affect the type of the data.

This allows a Map where the field names are key_value, key, value to be mapped to a entries, keys, values.

This can be helpful in merging record batches that may have come from different sources.  This also makes maps behave similar to lists which also have a field to distinguish their elements.
    @HawaiianSpork
    HawaiianSpork committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    2be41c6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
    @HawaiianSpork @alamb
    HawaiianSpork and alamb committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    185aa53 View commit details
    Browse the repository at this point in the history

  3. Feedback from code review 

    - simplify map casting logic to reuse the entries
- Added unit tests for negative cases
- Use MapBuilder to make the intended type clearer.
    @HawaiianSpork
    HawaiianSpork committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ffdc3bc View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @HawaiianSpork
    HawaiianSpork committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fbb0666 View commit details
    Browse the repository at this point in the history

  5. Lint and format

    @HawaiianSpork
    HawaiianSpork committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    521ce0c View commit details
    Browse the repository at this point in the history

  6. correctly set the null fields

    @HawaiianSpork
    HawaiianSpork committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ac3d85f View commit details
    Browse the repository at this point in the history