Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dyn syntax for trait objects #592

Merged
merged 1 commit into from
Jul 25, 2021
Merged

fix dyn syntax for trait objects #592

merged 1 commit into from
Jul 25, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jul 22, 2021

Which issue does this PR close?

Fixes some issues from #591, mostly because for trait objects we'll have to prefix the dyn keyword which is mandatory in rust 2021 edition.

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 22, 2021
@jimexist jimexist changed the title fix dyn syntax fix dyn syntax for trait objects Jul 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #592 (765f744) into master (87d2840) will increase coverage by 0.00%.
The diff coverage is 54.83%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files         167      167           
  Lines       46232    46232           
=======================================
+ Hits        38100    38101    +1     
+ Misses       8132     8131    -1     
Impacted Files Coverage Δ
arrow/src/array/array.rs 80.90% <ø> (ø)
arrow/src/array/transform/mod.rs 86.06% <ø> (ø)
arrow/src/compute/kernels/take.rs 94.72% <ø> (ø)
arrow/src/record_batch.rs 90.44% <ø> (ø)
arrow/src/array/builder.rs 86.11% <22.85%> (ø)
arrow/src/array/ord.rs 63.33% <83.33%> (ø)
arrow/src/array/array_binary.rs 92.23% <100.00%> (ø)
arrow/src/array/array_boolean.rs 94.01% <100.00%> (ø)
arrow/src/array/array_dictionary.rs 88.38% <100.00%> (ø)
arrow/src/array/array_list.rs 95.51% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d2840...765f744. Read the comment docs.

@jimexist jimexist marked this pull request as ready for review July 22, 2021 02:29
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome -- thank you @jimexist

@alamb alamb merged commit 04d6b63 into apache:master Jul 25, 2021
@jimexist jimexist deleted the fix-dyn branch July 25, 2021 13:48
alamb pushed a commit that referenced this pull request Jul 27, 2021
alamb added a commit that referenced this pull request Jul 28, 2021
Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants