-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats) #662
Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats) #662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
==========================================
- Coverage 82.50% 82.43% -0.07%
==========================================
Files 168 168
Lines 47249 47325 +76
==========================================
+ Hits 38984 39014 +30
- Misses 8265 8311 +46
Continue to review full report at Codecov.
|
67add39
to
f99c351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue does this PR close?
Resolves #660
Rationale for this change
FixedLenByteArray columns were writing the wrong type of statistics
What changes are included in this PR?
Write FixedLenByteArray stats for FixedLenByteArray columns (not ByteArray stats)
Are there any user-facing changes?
FixedLenByteArray statistics are written rather than ByteArray statistics. I am not sure if this is a user visible change however (see description on #661 (comment))