Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Use latest nightly for MIRI runs #907

Closed
wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 2, 2021

Which issue does this PR close?

Re #879

Rationale for this change

try to get a reliably passing MIRI run

The symptoms of the failing MIRI runs seem to be the same as would happen if the system OOM'd -- #879 (comment) so try running with latest nightly to see if that helps

I admit this is likely grasping at straws 🥤

@codecov-commenter
Copy link

Codecov Report

Merging #907 (0495bd0) into master (b79c600) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0495bd0 differs from pull request most recent head e384ff1. Consider uploading reports for the commit e384ff1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   82.30%   82.30%   -0.01%     
==========================================
  Files         168      168              
  Lines       48026    48026              
==========================================
- Hits        39529    39528       -1     
- Misses       8497     8498       +1     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 85.20% <0.00%> (-0.14%) ⬇️
arrow/src/datatypes/datatype.rs 65.36% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79c600...e384ff1. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Nov 2, 2021

@alamb
Copy link
Contributor Author

alamb commented Nov 3, 2021

@alamb
Copy link
Contributor Author

alamb commented Nov 3, 2021

@alamb
Copy link
Contributor Author

alamb commented Nov 3, 2021

I think the next best thing may be to disable the failing test in MIRI. Will try that

@alamb
Copy link
Contributor Author

alamb commented Nov 3, 2021

Closing in favor of #910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants