Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Adding ability to parse float from number with leading decimal to active_release #962

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 20, 2021

Automatic cherry-pick of ece8a7c

* Adding ability to parse float from number with leading decimal

* Fixing deprecated std::usize::MAX constant per https://doc.rust-lang.org/core/usize/constant.MAX.html and making consistent with other usages

* Add test case for 2. and issue link

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #962 (7883476) into active_release (54023c8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #962      +/-   ##
==================================================
+ Coverage           82.38%   82.40%   +0.01%     
==================================================
  Files                 168      168              
  Lines               48668    48670       +2     
==================================================
+ Hits                40097    40105       +8     
+ Misses               8571     8565       -6     
Impacted Files Coverage Δ
arrow/src/csv/reader.rs 90.02% <100.00%> (+0.02%) ⬆️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.27%) ⬆️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (+0.42%) ⬆️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54023c8...7883476. Read the comment docs.

@alamb alamb merged commit f7deba4 into active_release Nov 22, 2021
@alamb alamb deleted the cherry_pick_ece8a7c3 branch November 22, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants