Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos in code and comments #985

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

jimexist
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

fix typos in code and comment, because cleaner code and typo free code is more search friendly

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #985 (f96c5b0) into master (f6908bf) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         168      168           
  Lines       48761    48761           
=======================================
  Hits        40136    40136           
  Misses       8625     8625           
Impacted Files Coverage Δ
arrow/src/buffer/immutable.rs 97.84% <ø> (ø)
arrow/src/buffer/mutable.rs 89.47% <ø> (ø)
arrow/src/bytes.rs 56.25% <ø> (ø)
arrow/src/compute/kernels/arity.rs 86.36% <ø> (ø)
arrow/src/compute/kernels/cast_utils.rs 87.50% <ø> (ø)
arrow/src/csv/reader.rs 90.58% <ø> (ø)
arrow/src/datatypes/schema.rs 66.93% <ø> (ø)
arrow/src/compute/kernels/filter.rs 89.55% <33.33%> (ø)
arrow/src/compute/kernels/cast.rs 94.81% <100.00%> (ø)
arrow/src/datatypes/field.rs 53.37% <0.00%> (-0.31%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6908bf...f96c5b0. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @jimexist -- keeping things neat and tidy 🧹 thank you

@alamb alamb merged commit 6a6e7f7 into apache:master Nov 29, 2021
@jimexist jimexist deleted the update-typos branch November 30, 2021 00:22
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Nov 30, 2021
alamb pushed a commit that referenced this pull request Dec 4, 2021
alamb pushed a commit that referenced this pull request Dec 5, 2021
alamb added a commit that referenced this pull request Dec 6, 2021
Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants