You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug, including details regarding any error messages, version, and platform.
The current JSON Chunker defers all error reporting to a later parsing stage when ParseOptions::newlines_in_values = true. However, this poses issues when sequentially chunking buffers. Consider this:
Here, whole will be {"a":0} but rest will be }, which doesn't start a valid JSON block. As such, for the next buffer, you can't then call ProcessWithPartial with rest as its partial argument without crashing (via DCHECK, if enabled). This effectively prevents us from handling the error at all.
Component(s)
C++
The text was updated successfully, but these errors were encountered:
Describe the bug, including details regarding any error messages, version, and platform.
The current JSON
Chunker
defers all error reporting to a later parsing stage whenParseOptions::newlines_in_values = true
. However, this poses issues when sequentially chunking buffers. Consider this:Here,
whole
will be{"a":0}
butrest
will be}
, which doesn't start a valid JSON block. As such, for the next buffer, you can't then callProcessWithPartial
withrest
as itspartial
argument without crashing (via DCHECK, if enabled). This effectively prevents us from handling the error at all.Component(s)
C++
The text was updated successfully, but these errors were encountered: