Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Packaging][deb] Debian GNU/Linux bookworm provides Protobuf 3.21.11 #15012

Closed
kou opened this issue Dec 17, 2022 · 0 comments · Fixed by #15013
Closed

[Packaging][deb] Debian GNU/Linux bookworm provides Protobuf 3.21.11 #15012

kou opened this issue Dec 17, 2022 · 0 comments · Fixed by #15013
Assignees
@kou
Labels
Component: Packaging Type: enhancement
Milestone
11.0.0

Comments

@kou
Copy link
Member

kou commented Dec 17, 2022

Describe the enhancement requested

https://packages.debian.org/search?keywords=libprotobuf-dev

Flight requires Protobuf 3.15.0 or later. We can use system Protobuf for Flight now.

We need to add libprotobuf-dev dependency to libarrow-dev. Because ArrowConfig.cmake finds Protobuf.

debian-bookworm-amd64 is failing by this:

https://github.com/ursacomputing/crossbow/actions/runs/3719263437/jobs/6308012451

  -- Could NOT find Protobuf (missing: Protobuf_LIBRARIES Protobuf_INCLUDE_DIR) 
  CMake Error at CMakeLists.txt:24 (find_package):
    Found package configuration file:
  
      /usr/lib/x86_64-linux-gnu/cmake/Arrow/ArrowConfig.cmake
  
    but it set Arrow_FOUND to FALSE so package "Arrow" is considered to be NOT
    FOUND.  Reason given by package:
  
    Arrow could not be found because dependency ProtobufAlt could not be found.
  
  
  
  -- Configuring incomplete, errors occurred!

Component(s)

Packaging
kou added a commit to kou/arrow that referenced this issue Dec 17, 2022
@kou
apacheGH-15012: [Packaging][deb] Use system Protobuf for Debian GNU/L…
77a5aac 
…inux bookworm

libprotobuf-dev on Debian GNU/Linux bookworm is now 3.21.11:

https://packages.debian.org/search?keywords=libprotobuf-dev

We can use it for our package.

This fixes the following package test failure:

https://github.com/ursacomputing/crossbow/actions/runs/3719263437/jobs/6308012451

    -- Could NOT find Protobuf (missing: Protobuf_LIBRARIES Protobuf_INCLUDE_DIR)
    CMake Error at CMakeLists.txt:24 (find_package):
      Found package configuration file:

        /usr/lib/x86_64-linux-gnu/cmake/Arrow/ArrowConfig.cmake

      but it set Arrow_FOUND to FALSE so package "Arrow" is considered to be NOT
      FOUND.  Reason given by package:

      Arrow could not be found because dependency ProtobufAlt could not be found.

    -- Configuring incomplete, errors occurred!
@github-actions github-actions bot mentioned this issue Dec 17, 2022
Merged
kou added a commit that referenced this issue Dec 17, 2022
@kou
GH-15012: [Packaging][deb] Use system Protobuf for Debian GNU/Linux b…
2c768a1 
…ookworm (#15013)

libprotobuf-dev on Debian GNU/Linux bookworm is now 3.21.11:

https://packages.debian.org/search?keywords=libprotobuf-dev

We can use it for our package.

This fixes the following package test failure:

https://github.com/ursacomputing/crossbow/actions/runs/3719263437/jobs/6308012451

    -- Could NOT find Protobuf (missing: Protobuf_LIBRARIES Protobuf_INCLUDE_DIR)
    CMake Error at CMakeLists.txt:24 (find_package):
      Found package configuration file:

        /usr/lib/x86_64-linux-gnu/cmake/Arrow/ArrowConfig.cmake

      but it set Arrow_FOUND to FALSE so package "Arrow" is considered to be NOT
      FOUND.  Reason given by package:

      Arrow could not be found because dependency ProtobufAlt could not be found.

    -- Configuring incomplete, errors occurred!
* Closes: #15012

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 11.0.0 milestone Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Packaging Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15012: [Packaging][deb] Use system Protobuf for Debian GNU/Linux bookworm kou/arrow
1 participant
@kou