Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby] Use common keys when keys.nil? in Table#join #15084

Closed
heronshoes opened this issue Dec 24, 2022 · 2 comments · Fixed by #15088
Closed

[Ruby] Use common keys when keys.nil? in Table#join #15084

heronshoes opened this issue Dec 24, 2022 · 2 comments · Fixed by #15088
Assignees
@heronshoes
Labels
Component: Ruby Type: enhancement
Milestone
11.0.0

Comments

@heronshoes
Copy link
Contributor

Describe the enhancement requested

Target method

Arrow::Table#join

Target argument

keys

Proposed feature

Implicit common key(s) will used when keys is nil.

Impact of this request

keys will become an optional argument and nil may be the default value (keys = nil).

Reference of this request

I am testing this feature in RedAmber on the line below.

https://github.com/heronshoes/red_amber/blob/main/lib/red_amber/data_frame_combinable.rb#L382-L383

Component(s)

Ruby
@kou
Copy link
Member

kou commented Dec 24, 2022

Let's implement this!
Do you want to open a pull request for this?

@heronshoes
Copy link
Contributor Author

Thanks! I will try.

heronshoes added a commit to heronshoes/arrow that referenced this issue Dec 25, 2022
@heronshoes
apacheGH-15084: [Ruby] Use common keys when keys.nil? in Table#join
7ec7bd4
@heronshoes heronshoes mentioned this issue Dec 25, 2022
Merged
heronshoes added a commit to heronshoes/arrow that referenced this issue Dec 26, 2022
@heronshoes
apacheGH-15084: [Ruby] Use common keys when keys.nil? in Table#join
390f39c
heronshoes added a commit to heronshoes/arrow that referenced this issue Dec 27, 2022
@heronshoes
apacheGH-15084: [Ruby] Use common keys when keys.nil? in Table#join
93a05f2
@kou kou closed this as completed in #15088 Jan 5, 2023
kou added a commit that referenced this issue Jan 5, 2023
@heronshoes @kou
GH-15084: [Ruby] Use common keys when keys.nil? in Table#join (#15088)
25b5093 
### What I did

* Add support for `keys = nil` in `Table#join`
  * When `keys.nil?` common keys in self and right will automatically set to keys.
* Add assertions without argument keys.
* Add missing comments for other overload cases.

### What I checked

* It works the same way in RedAmber.

### Related Issue

* Closes: #15084

Lead-authored-by: Hirokazu SUZUKI (heronshoes) <heronshoes877@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 11.0.0 milestone Jan 5, 2023
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@heronshoes @kou @EpsilonPrime
apacheGH-15084: [Ruby] Use common keys when keys.nil? in Table#join (a…
0489b6c 
…pache#15088)

### What I did

* Add support for `keys = nil` in `Table#join`
  * When `keys.nil?` common keys in self and right will automatically set to keys.
* Add assertions without argument keys.
* Add missing comments for other overload cases.

### What I checked

* It works the same way in RedAmber.

### Related Issue

* Closes: apache#15084

Lead-authored-by: Hirokazu SUZUKI (heronshoes) <heronshoes877@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
@heronshoes @kou @vibhatha
apacheGH-15084: [Ruby] Use common keys when keys.nil? in Table#join (a…
1c14a8a 
…pache#15088)

### What I did

* Add support for `keys = nil` in `Table#join`
  * When `keys.nil?` common keys in self and right will automatically set to keys.
* Add assertions without argument keys.
* Add missing comments for other overload cases.

### What I checked

* It works the same way in RedAmber.

### Related Issue

* Closes: apache#15084

Lead-authored-by: Hirokazu SUZUKI (heronshoes) <heronshoes877@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heronshoes heronshoes

Labels
Component: Ruby Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15084: [Ruby] Use common keys when keys.nil? in Table#join heronshoes/arrow
3 participants
@kou @assignUser @heronshoes