Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Pass std::string_view by value, not by const-ref #15171

Closed
pitrou opened this issue Jan 3, 2023 · 2 comments · Fixed by #33684
Closed

[C++] Pass std::string_view by value, not by const-ref #15171

pitrou opened this issue Jan 3, 2023 · 2 comments · Fixed by #33684
Labels
Component: C++ good-first-issue Type: enhancement
Milestone
12.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jan 3, 2023

Describe the enhancement requested

See https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/

Component(s)

C++
@pitrou pitrou mentioned this issue Jan 3, 2023
Merged
@madhavarora03
Copy link

madhavarora03 commented Jan 4, 2023 •
edited
Loading

Hi, I would like to contribute to this

@pitrou
Copy link
Member Author

pitrou commented Jan 4, 2023

@madhavarora03 You can, feel free to submit a PR!

@ucasfl ucasfl mentioned this issue Jan 16, 2023
Merged
cyb70289 pushed a commit that referenced this issue Jan 17, 2023
@ucasfl @pitrou
GH-15171: [C++] Pass std::string_view by value (#33684)
641d1da 
# Which issue does this PR close?

Closes #15171. 

# Rationale for this change

# What changes are included in this PR?

Pass std::string_view by value, not by const-ref
# Are these changes tested?

# Are there any user-facing changes?
No.

* Closes: #15171

Lead-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
@cyb70289 cyb70289 added this to the 12.0.0 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ good-first-issue Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-15171: [C++] Pass std::string_view by value ucasfl/arrow
3 participants
@pitrou @cyb70289 @madhavarora03