Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Expose FlightService_ServiceDesc and RegisterFlightServiceServer #15174

Closed
zeroshade opened this issue Jan 3, 2023 · 0 comments · Fixed by #15177
Closed

[Go] Expose FlightService_ServiceDesc and RegisterFlightServiceServer #15174

zeroshade opened this issue Jan 3, 2023 · 0 comments · Fixed by #15177
Assignees
@zeroshade
Labels
Component: FlightRPC Component: Go Type: enhancement
Milestone
11.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

In order to incorporate a flight service into an existing grpc server, it is required to expose the Service Descriptor for the flight service. We should also expose the convenience function of RegisterFlightServiceServer as a convenient use to register a Flight service onto an existing grpc.ServiceRegistrar.

Component(s)

FlightRPC, Go
zeroshade added a commit to zeroshade/arrow that referenced this issue Jan 3, 2023
@zeroshade
apacheGH-15174: [Go][FlightRPC] Expose Flight Server Desc and Registe…
b636316 
…rFlightService
@github-actions github-actions bot mentioned this issue Jan 3, 2023
Merged
zeroshade added a commit that referenced this issue Jan 3, 2023
@zeroshade
GH-15174: [Go][FlightRPC] Expose Flight Server Desc and RegisterFligh…
ec9a8a3 
…tService (#15177)

CC @ mariusvniekerk 
* Closes: #15174

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 11.0.0 milestone Jan 3, 2023
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@zeroshade @EpsilonPrime
apacheGH-15174: [Go][FlightRPC] Expose Flight Server Desc and Registe…
c6c93de 
…rFlightService (apache#15177)

CC @ mariusvniekerk 
* Closes: apache#15174

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@zeroshade @EpsilonPrime
apacheGH-15174: [Go][FlightRPC] Expose Flight Server Desc and Registe…
f32e946 
…rFlightService (apache#15177)

CC @ mariusvniekerk 
* Closes: apache#15174

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
@zeroshade @vibhatha
apacheGH-15174: [Go][FlightRPC] Expose Flight Server Desc and Registe…
2203b5e 
…rFlightService (apache#15177)

CC @ mariusvniekerk 
* Closes: apache#15174

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: FlightRPC Component: Go Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15174: [Go][FlightRPC] Expose Flight Server Desc and RegisterFlightService zeroshade/arrow
1 participant
@zeroshade