Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use DeclarationToExecBatches in Acero plan tests #15284

Closed
vibhatha opened this issue Jan 10, 2023 · 1 comment · Fixed by #15288
Closed

[C++] Use DeclarationToExecBatches in Acero plan tests #15284

vibhatha opened this issue Jan 10, 2023 · 1 comment · Fixed by #15288
Assignees
@vibhatha
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@vibhatha
Copy link
Collaborator

Describe the enhancement requested

The DeclarationToExecBatches provides a much neater way to enhance the existing test cases in plan_test.cc.

Component(s)

C++
@vibhatha
Copy link
Collaborator Author

take

@github-actions github-actions bot mentioned this issue Jan 10, 2023
Merged
5 tasks
westonpace added a commit that referenced this issue Jan 20, 2023
@vibhatha @westonpace
GH-15284: [C++] Use DeclarationToExecBatches in Acero plan tests (#15288
0e4a2e1 
)

This PR includes a change to the existing test cases in `plan_test.cc` for Acero-based plan evaluation. 

At the moment, using the `StartAndCollect` method and manually passing the `FutureMatcher` and expected results are done and the validation is done on the results obtained from the `StartAndCollect` method. Most of the updated test cases in this PR uses the a common format. 

Replacing that format and using `DeclarationToExecBatches` makes the code more readable and easy to debug. 
### TODO
- [x] Convert other tests with sort options and custom sinks
- [x] Self review 1
- [x] Self review 2
- [x] Check CI Status
- [x] Mark Ready to Review

* Closes: #15284

Lead-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@users.noreply.github.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Jan 20, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@vibhatha @westonpace @sjperkins
apacheGH-15284: [C++] Use DeclarationToExecBatches in Acero plan tests (
8ab09ed 
apache#15288)

This PR includes a change to the existing test cases in `plan_test.cc` for Acero-based plan evaluation. 

At the moment, using the `StartAndCollect` method and manually passing the `FutureMatcher` and expected results are done and the validation is done on the results obtained from the `StartAndCollect` method. Most of the updated test cases in this PR uses the a common format. 

Replacing that format and using `DeclarationToExecBatches` makes the code more readable and easy to debug. 
### TODO
- [x] Convert other tests with sort options and custom sinks
- [x] Self review 1
- [x] Self review 2
- [x] Check CI Status
- [x] Mark Ready to Review

* Closes: apache#15284

Lead-authored-by: vibhatha <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@users.noreply.github.com>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-15284: [C++] Use DeclarationToExecBatches in Acero plan tests vibhatha/arrow
2 participants
@westonpace @vibhatha