Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Documentation] Note caveats of a combined gRPC/Flight server #30204

Closed
asfimport opened this issue Nov 10, 2021 · 3 comments
Closed

[C++][Documentation] Note caveats of a combined gRPC/Flight server #30204

asfimport opened this issue Nov 10, 2021 · 3 comments

Comments

@asfimport
Copy link
Collaborator

See this GitHub issue: when building a combined gRPC/Flight service, care must be taken not to link gRPC twice on accident. This is noted briefly in the docstring but we should be more detailed and perhaps add prose documentation. We should also note this in the example.

Reporter: David Li / @lidavidm
Assignee: David Li / @lidavidm

PRs and other links:

Note: This issue was originally created as ARROW-14662. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Also see the related Cookbook issue.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Looking at the Ubuntu 20.04 package:

  • Ubuntu ships gRPC 1.3 (yikes!) so we build gRPC from source.

  • We can't/don't want to distribute libgrpc++.so, so we link gRPC statically.

  • We include gRPC and Protobuf in libarrow_bundled_dependencies.a

    So we should note that applications expecting to use solely Arrow Flight, but not Protobuf or gRPC, can use either the dynamic or static libraries, but applications that may include either Protobuf or gRPC must (1) use the static libraries and (2) use the same version of Protobuf as Arrow. That's rather a pain and it may be easier to just build Arrow from source…

@asfimport
Copy link
Collaborator Author

Yibo Cai / @cyb70289:
Issue resolved by pull request 11698
#11698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants