Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Update rhub/fedora-clang-devel for upstreamed changes #31549

Closed
asfimport opened this issue Apr 7, 2022 · 3 comments
Closed

[R] Update rhub/fedora-clang-devel for upstreamed changes #31549

asfimport opened this issue Apr 7, 2022 · 3 comments
Assignees
Milestone

Comments

@asfimport
Copy link
Collaborator

In ARROW-15857 we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image.

Reporter: Dewey Dunnington / @paleolimbot
Assignee: Dewey Dunnington / @paleolimbot

PRs and other links:

Note: This issue was originally created as ARROW-16141. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
I tried removing some of this special casing (the parts they took upstream) in ARROW-16752 but had inconsistent results, not sure why (cached docker images?). But anyway I found that we can't yet remove all of the Makevars munging because we edit LDFLAGS and others to be sure that libc++ and only libc++ is used.

@asfimport
Copy link
Collaborator Author

Dewey Dunnington / @paleolimbot:
The sass change isn't on CRAN yet ( https://github.com/rstudio/sass/releases says that the issue was merged but there was a bad merge somewhere and the change isn't actually in the release), so that may be the issue!

@asfimport
Copy link
Collaborator Author

Dewey Dunnington / @paleolimbot:
Issue resolved by pull request 12824
#12824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants