ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes #12824
Conversation
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: fa02aa5 Submitted crossbow builds: ursacomputing/crossbow @ actions-1827
|
|
(This is failing because the latest release of the 'sass' package didn't actually contain the upstreamed fix despite the NEWS bullet indicating that it was, so we have to wait for 0.4.2 to be released: https://github.com/rstudio/sass/releases). |
|
As per ARROW-16310, we also need to make sure that test-fedora-r-clang-sanitizer passes since the current Makefile modifications might be affecting the install of tzdb. |
|
@paleolimbot What's the status on this? Should this PR be kept open? |
paleolimbot
force-pushed
the
r-rhub-fedora-clang
branch
from
fa02aa5
to
8b5875d
Compare
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: d6cfe59 Submitted crossbow builds: ursacomputing/crossbow @ actions-32da4d031b
|
|
This looks like it works...I was waiting on a release of the 'sass' package that didn't properly pick up linker flags from the |
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: 3c439de Submitted crossbow builds: ursacomputing/crossbow @ actions-c95ef40d0f
|
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: 45b7556 Submitted crossbow builds: ursacomputing/crossbow @ actions-c9fd68f714
|
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: 45b7556 Submitted crossbow builds: ursacomputing/crossbow @ actions-7509e9f2b3
|
|
@paleolimbot I re-ran the failed job with |
|
I can't personally explain the previous failure (the code chunk I added back in seems pretty well fenced to the one image). Thanks for taking a look! I need to open up the image locally to make sure that gnu extensions are not being loaded with those Makevars (I can't see why they would be with those flags but seeing as the image has one job...) |
|
@github-actions crossbow submit test-r-linux-as-cran |
|
I investigated this, and the rhub image doesn't need anything additional to ensure that libc++ is getting used even with the # docker run --rm -it rhub/fedora-clang-devel bash
printf "#include <ciso646>\n#ifdef _LIBCPP_VERSION\n#error Using libc++\n#endif" > test.cpp
/opt/R-devel/bin/R CMD SHLIB test.cpp
# /usr/bin/clang++ -std=gnu++14 -stdlib=libc++ -I"/opt/R-devel/lib64/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c test.cpp -o test.o
# test.cpp:3:2: error: Using libc++
# #error Using libc++
# ^
# 1 error generated.
/usr/bin/clang++ -stdlib=libc++ -I/usr/local/include -g -O2 -std=gnu++11 -E test.cpp | head -n 1
# test.cpp:3:2: error: Using libc++
# #error Using libc++
# ^
# 1 error generated. |
|
Revision: 1748b23 Submitted crossbow builds: ursacomputing/crossbow @ actions-d762bd3886
|
|
Benchmark runs are scheduled for baseline = 3c13dc4 and contender = c90d07f. c90d07f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
apache#12824) In ARROW-15857 (apache#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image. Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com> Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
apache#12824) In ARROW-15857 (apache#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image. Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com> Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
In ARROW-15857 (#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image.