Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Substrait To Arrow Emit feature testing #32747

Closed
Tracked by #32721
asfimport opened this issue Aug 22, 2022 · 0 comments · Fixed by #14174
Closed
Tracked by #32721

[C++] Substrait To Arrow Emit feature testing #32747

asfimport opened this issue Aug 22, 2022 · 0 comments · Fixed by #14174
Labels
Component: C++ Type: task
Milestone
12.0.0

Comments

@asfimport
Copy link
Collaborator

At the moment, the emit feature is tested with respect to each relation. It can be further tested with the combination of other relations. https://issues.apache.org/jira/browse/ARROW-15584 contains the basic tests. Since this PR is already a bit lengthy one, decided to include the rest of the effort as a sub-task to the parent task which covers Substrait end-to-end tests. 

Reporter: Vibhatha Lakmal Abeykoon / @vibhatha
Assignee: Vibhatha Lakmal Abeykoon / @vibhatha

PRs and other links:

Note: This issue was originally created as ARROW-17486. Please see the migration documentation for further details.
@asfimport asfimport mentioned this issue Jan 11, 2023
Open
2 tasks
@github-actions github-actions bot mentioned this issue Jan 25, 2023
Merged
westonpace pushed a commit that referenced this issue Jan 25, 2023
@vibhatha
GH-32747: [C++] Substrait To Arrow Emit feature testing (#14174)
3b3afc0 
Adding compound tests for Substrait Emit. This is an extension to previous tests which only included emit testing only with a particular operator + read.

Also the util functions used in tests are moved to `test_util.cc` where future tests including compound relations can re-use this logic.
* Closes: #32747

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Jan 25, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@vibhatha @sjperkins
apacheGH-32747: [C++] Substrait To Arrow Emit feature testing (apache…
c209313 
…#14174)

Adding compound tests for Substrait Emit. This is an extension to previous tests which only included emit testing only with a particular operator + read.

Also the util functions used in tests are moved to `test_util.cc` where future tests including compound relations can re-use this logic.
* Closes: apache#32747

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Co-authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Type: task
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-32747: [C++] Substrait To Arrow Emit feature testing vibhatha/arrow
2 participants
@westonpace @asfimport