Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flight.Server to register additional grpc services #32805

Closed
asfimport opened this issue Aug 29, 2022 · 1 comment
Closed

Enable flight.Server to register additional grpc services #32805

asfimport opened this issue Aug 29, 2022 · 1 comment

Comments

@asfimport
Copy link
Collaborator

The grpc.Server is unexported within flight.Server (code ref); therefore, it's not possible to register additional grpc services, such as health check, reflection, on the flight.Server.

Usage:

import (
	"google.golang.org/grpc/health"
	"google.golang.org/grpc/health/grpc_health_v1"
	"google.golang.org/grpc/reflection"
)


	s := flight.NewFlightServer()

	// Enable health check.
	grpc_health_v1.RegisterHealthServer(s, health.NewServer())

	// Enable reflection for grpcurl.
	reflection.Register(s)

Reporter: Jie Zhang / @jiezhang
Assignee: Jie Zhang / @jiezhang

PRs and other links:

Note: This issue was originally created as ARROW-17553. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Matthew Topol / @zeroshade:
Issue resolved by pull request 13995
#13995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant