ARROW-17553: [Go] Enable flight.Server to register additional grpc services #13995
Conversation
|
@jiezhang Thanks for the contribution, could you add a test for this? |
jiezhang
force-pushed
the
server
branch
2 times, most recently
from
4a2860e
to
5449dd5
Compare
|
@zeroshade I added a unit test. Can you please take another look? |
jiezhang
changed the title
|
|
|
Looks good to me, once all the checks succeed i'll merge it :) Thanks again! |
|
Benchmark runs are scheduled for baseline = b8c04c8 and contender = 07e7009. 07e7009 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…rvices (apache#13995) This PR exposes `grpc.ServiceRegistrar` and `reflection.ServiceInfoProvider` in `grpc.Server`. They are needed to register additional gRPC services such as health check and reflection. Authored-by: Jie Zhang <zhangjie@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…rvices (apache#13995) This PR exposes `grpc.ServiceRegistrar` and `reflection.ServiceInfoProvider` in `grpc.Server`. They are needed to register additional gRPC services such as health check and reflection. Authored-by: Jie Zhang <zhangjie@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…rvices (apache#13995) This PR exposes `grpc.ServiceRegistrar` and `reflection.ServiceInfoProvider` in `grpc.Server`. They are needed to register additional gRPC services such as health check and reflection. Authored-by: Jie Zhang <zhangjie@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
This PR exposes
grpc.ServiceRegistrarandreflection.ServiceInfoProvideringrpc.Server. They are needed to register additional gRPC services such as health check and reflection.