Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] semi_join and anti_join function signatures in Arrow differ from dplyr #33709

Closed
thisisnic opened this issue Jan 16, 2023 · 4 comments · Fixed by #34030
Closed

[R] semi_join and anti_join function signatures in Arrow differ from dplyr #33709

thisisnic opened this issue Jan 16, 2023 · 4 comments · Fixed by #34030
Assignees
@thisisnic
Labels
Component: R Type: bug
Milestone
12.0.0

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Both semi_join() and anti_join() have argument suffix, which don't exist in the dplyr implementation.

Component(s)

R
@thisisnic thisisnic mentioned this issue Jan 16, 2023
Merged
@nealrichardson
Copy link
Member

Is this issue resolved?

@thisisnic
Copy link
Member Author

Nope

@nealrichardson
Copy link
Member

Oh sorry, I saw the merged PR that seemed to address it and was wondering if this was unintentionally left open.

@thisisnic
Copy link
Member Author

Sorry, I didn't update the PR title to reflect what actually got changed in the end.

@thisisnic thisisnic self-assigned this Feb 3, 2023
@github-actions github-actions bot mentioned this issue Feb 3, 2023
Merged
thisisnic added a commit that referenced this issue Feb 6, 2023
@thisisnic
GH-33709: [R] Remove suffix argument from semi_join and anti_join (#3…
32c7130 
…4030)

The function signatures for `semi_join()` and `anti_join()` don't match those of dplyr.  This PR removes the argument `suffix` from `anti_join()` and `semi_join()`. Is this change necessary/useful or just pedantic? Unsure.

* Closes: #33709

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 12.0.0 milestone Feb 6, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@thisisnic @sjperkins
apacheGH-33709: [R] Remove suffix argument from semi_join and anti_jo…
80073e5 
…in (apache#34030)

The function signatures for `semi_join()` and `anti_join()` don't match those of dplyr.  This PR removes the argument `suffix` from `anti_join()` and `semi_join()`. Is this change necessary/useful or just pedantic? Unsure.

* Closes: apache#33709

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@thisisnic
apacheGH-33709: [R] Remove suffix argument from semi_join and anti_jo…
dd56fb4 
…in (apache#34030)

The function signatures for `semi_join()` and `anti_join()` don't match those of dplyr.  This PR removes the argument `suffix` from `anti_join()` and `semi_join()`. Is this change necessary/useful or just pedantic? Unsure.

* Closes: apache#33709

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@thisisnic @fatemehp
apacheGH-33709: [R] Remove suffix argument from semi_join and anti_jo…
36b22cd 
…in (apache#34030)

The function signatures for `semi_join()` and `anti_join()` don't match those of dplyr.  This PR removes the argument `suffix` from `anti_join()` and `semi_join()`. Is this change necessary/useful or just pedantic? Unsure.

* Closes: apache#33709

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33709: [R] Remove suffix argument from semi_join and anti_join thisisnic/arrow
2 participants
@nealrichardson @thisisnic