[Go][FlightSQL] Allow passing grpc call options to prepared statement methods #33867
Comments
zeroshade
added a commit
to zeroshade/arrow
that referenced
this issue
Jan 25, 2023
…epared statement methods
zeroshade
added a commit
that referenced
this issue
Jan 25, 2023
…Statement methods (#33868) ### Rationale for this change To allow propagating timeouts among other call options when using PreparedStatements with FlightSQL we need to update the function signatures to allow passing the call options to them. ### Are there any user-facing changes? The signatures for the methods on PreparedStatement objects have been updated to accept `opts... grpc.CallOption` as their last parameter. This shouldn't break any existing usage of the methods (since they are optional) but would cause a problem if consumers set up interfaces based on them. * Closes: #33867 Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
sjperkins
pushed a commit
to sjperkins/arrow
that referenced
this issue
Feb 10, 2023
…eparedStatement methods (apache#33868) ### Rationale for this change To allow propagating timeouts among other call options when using PreparedStatements with FlightSQL we need to update the function signatures to allow passing the call options to them. ### Are there any user-facing changes? The signatures for the methods on PreparedStatement objects have been updated to accept `opts... grpc.CallOption` as their last parameter. This shouldn't break any existing usage of the methods (since they are optional) but would cause a problem if consumers set up interfaces based on them. * Closes: apache#33867 Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
gringasalpastor
pushed a commit
to gringasalpastor/arrow
that referenced
this issue
Feb 17, 2023
…eparedStatement methods (apache#33868) ### Rationale for this change To allow propagating timeouts among other call options when using PreparedStatements with FlightSQL we need to update the function signatures to allow passing the call options to them. ### Are there any user-facing changes? The signatures for the methods on PreparedStatement objects have been updated to accept `opts... grpc.CallOption` as their last parameter. This shouldn't break any existing usage of the methods (since they are optional) but would cause a problem if consumers set up interfaces based on them. * Closes: apache#33867 Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Currently you cannot pass
grpc.CallOptions to Execute/ExecuteUpdate/Close onflightsql.PreparedStatementobjects. We should allow passing call options so that they can get propagated, rather than just copying the call options which were used for thePrepareand just propagating those.Component(s)
Go
The text was updated successfully, but these errors were encountered: