Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Column names should be case sensitive #33970

Closed
DanTm99 opened this issue Feb 1, 2023 · 0 comments · Fixed by #33978
Closed

[C#] Column names should be case sensitive #33970

DanTm99 opened this issue Feb 1, 2023 · 0 comments · Fixed by #33978
Assignees
Milestone

Comments

@DanTm99
Copy link
Contributor

DanTm99 commented Feb 1, 2023

Describe the bug, including details regarding any error messages, version, and platform.

In the Schema constructor in Schema.cs, the casing of field names is ignored when constructing the _fieldsDictionary (by using StringComparer.OrdinalIgnoreCase when constructing the dictionary).

This disallows multiple fields whose name only differs in casing, even though it should be allowed.

Component(s)

C#

@DanTm99 DanTm99 changed the title Column names should be case sensitive [C#] Column names should be case sensitive Feb 1, 2023
DanTm99 added a commit to DanTm99/arrow that referenced this issue Feb 6, 2023
eerhardt pushed a commit that referenced this issue Feb 6, 2023
Remove the use of a comparer that ignores casing when building the fields dictionary for a schema. 

This allows for fields with names that differ only in casing.

Currently, fields with names that only differ in casing will be seen as having the same name and will cause an Exception to be thrown due to being seen as having duplicate keys.
* Closes: #33970

Authored-by: Danyaal Khan <danyaal99@hotmail.co.uk>
Signed-off-by: Eric Erhardt <eric.erhardt@microsoft.com>
@eerhardt eerhardt added this to the 12.0.0 milestone Feb 6, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
…3978)

Remove the use of a comparer that ignores casing when building the fields dictionary for a schema. 

This allows for fields with names that differ only in casing.

Currently, fields with names that only differ in casing will be seen as having the same name and will cause an Exception to be thrown due to being seen as having duplicate keys.
* Closes: apache#33970

Authored-by: Danyaal Khan <danyaal99@hotmail.co.uk>
Signed-off-by: Eric Erhardt <eric.erhardt@microsoft.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
…3978)

Remove the use of a comparer that ignores casing when building the fields dictionary for a schema. 

This allows for fields with names that differ only in casing.

Currently, fields with names that only differ in casing will be seen as having the same name and will cause an Exception to be thrown due to being seen as having duplicate keys.
* Closes: apache#33970

Authored-by: Danyaal Khan <danyaal99@hotmail.co.uk>
Signed-off-by: Eric Erhardt <eric.erhardt@microsoft.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
…3978)

Remove the use of a comparer that ignores casing when building the fields dictionary for a schema. 

This allows for fields with names that differ only in casing.

Currently, fields with names that only differ in casing will be seen as having the same name and will cause an Exception to be thrown due to being seen as having duplicate keys.
* Closes: apache#33970

Authored-by: Danyaal Khan <danyaal99@hotmail.co.uk>
Signed-off-by: Eric Erhardt <eric.erhardt@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants