[C++] Add an array_span_mutable interface to ExecResult #34007
Comments
js8544
added a commit
to js8544/arrow
that referenced
this issue
Feb 2, 2023
westonpace
pushed a commit
that referenced
this issue
Feb 3, 2023
…4008) ### Rationale for this change Like for Buffer, we separate two interface for getting the underlying `array_span` for `ExecResult`, one const and one mutable. This avoids the awkward `const_cast` we currently use. ### What changes are included in this PR? Add the new mutable interface and update current calls to this method. ### Are these changes tested? Tested with existing tests. ### Are there any user-facing changes? No. * Closes: #34007 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
sjperkins
pushed a commit
to sjperkins/arrow
that referenced
this issue
Feb 10, 2023
…lt (apache#34008) ### Rationale for this change Like for Buffer, we separate two interface for getting the underlying `array_span` for `ExecResult`, one const and one mutable. This avoids the awkward `const_cast` we currently use. ### What changes are included in this PR? Add the new mutable interface and update current calls to this method. ### Are these changes tested? Tested with existing tests. ### Are there any user-facing changes? No. * Closes: apache#34007 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
gringasalpastor
pushed a commit
to gringasalpastor/arrow
that referenced
this issue
Feb 17, 2023
…lt (apache#34008) ### Rationale for this change Like for Buffer, we separate two interface for getting the underlying `array_span` for `ExecResult`, one const and one mutable. This avoids the awkward `const_cast` we currently use. ### What changes are included in this PR? Add the new mutable interface and update current calls to this method. ### Are these changes tested? Tested with existing tests. ### Are there any user-facing changes? No. * Closes: apache#34007 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
fatemehp
pushed a commit
to fatemehp/arrow
that referenced
this issue
Feb 24, 2023
…lt (apache#34008) ### Rationale for this change Like for Buffer, we separate two interface for getting the underlying `array_span` for `ExecResult`, one const and one mutable. This avoids the awkward `const_cast` we currently use. ### What changes are included in this PR? Add the new mutable interface and update current calls to this method. ### Are these changes tested? Tested with existing tests. ### Are there any user-facing changes? No. * Closes: apache#34007 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
This is a child issue of #33628.
Like for Buffer, we separate two interface for getting the underlying
array_spanforExecResult, one const and one mutable. This avoids the awkwardconst_castwe currently use.Component(s)
C++
The text was updated successfully, but these errors were encountered: