-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][FlightRPC] Make warning about do_action stream less noisy #34047
Comments
This is just a warning, it shouldn't break anything.
Otherwise: just try list(do_action(...))
On Sun, Feb 5, 2023, at 00:27, Ziheng Wang wrote:
Describe the bug, including details regarding any error messages, version, and platform.
Hi @lidavidm <https://github.com/lidavidm> pyarrow 11.0 is breaking my arrow flight related code. I think you have a good sense what the problem is: /arrow/cpp/src/arrow/status.cc:137: DoAction result was not fully consumed: Cancelled: Flight cancelled call, with message: CANCELLED. Detail: Cancelled
I seem to be fully consuming the DoAction results, e.g. here is my code:
`for result in self.flight_client.do_action(action):
assert result.body.to_pybytes().decode("utf-8") == "True"
`
… Can you give some pointers on how to use Python to get results from do_action?
Component(s)
FlightRPC
—
Reply to this email directly, view it on GitHub <#34047>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQB34T6DA3PZECLJWKAUTWV424ZANCNFSM6AAAAAAURSMA64>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Can I disable this warning? |
Does I think a PR to remove the warning or change it to DEBUG level would be reasonable, it's probably a bit aggressive as-is. |
OK doing list() seems to work. But I still think this shouldn't be the default :-) |
It was basically a conflict between people who want this to be a proper iterator (in which case gRPC really wants you to drain the stream) and the original behavior which was to eagerly materialize the list. @marsupialtail do you want to leave this open? We could change it to not warn by default, at least. |
### Rationale for this change The warning added for when you fail to consume a result stream (and get the final error/success result) is a bit aggressive. Ignore it in most cases. ### What changes are included in this PR? Drop the warning to DEBUG level and don't log if it's just a cancellation. ### Are these changes tested? Existing tests cover it. ### Are there any user-facing changes? Users should see less inactionable warnings. * Closes: #34047 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
…apache#34182) ### Rationale for this change The warning added for when you fail to consume a result stream (and get the final error/success result) is a bit aggressive. Ignore it in most cases. ### What changes are included in this PR? Drop the warning to DEBUG level and don't log if it's just a cancellation. ### Are these changes tested? Existing tests cover it. ### Are there any user-facing changes? Users should see less inactionable warnings. * Closes: apache#34047 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Describe the bug, including details regarding any error messages, version, and platform.
Hi @lidavidm pyarrow 11.0 is breaking my arrow flight related code. I think you have a good sense what the problem is: /arrow/cpp/src/arrow/status.cc:137: DoAction result was not fully consumed: Cancelled: Flight cancelled call, with message: CANCELLED. Detail: Cancelled
I seem to be fully consuming the DoAction results, e.g. here is my code:
Can you give some pointers on how to use Python to get results from do_action?
Component(s)
FlightRPC
The text was updated successfully, but these errors were encountered: