Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Segmentation fault on unique compute function against empty arrays #34241

Closed
vincent-mercier opened this issue Feb 17, 2023 · 0 comments · Fixed by #34246
Closed

[C++] Segmentation fault on unique compute function against empty arrays #34241

vincent-mercier opened this issue Feb 17, 2023 · 0 comments · Fixed by #34246
Assignees
@westonpace
Labels
Component: C++ Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Milestone
12.0.0

Comments

@vincent-mercier
Copy link

vincent-mercier commented Feb 17, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Upgrading to pyarrow 11 on python 3.8, my team has found segmentation faults linked to empty arrays:

import pyarrow as pa
import pyarrow.compute as pc

col = pa.chunked_array([], type=pa.dictionary(index_type=pa.int32(), value_type=pa.string()))
pc.unique(col)  # Segfaults here

Output:
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

First few lines of pyarrow.show_info():

pyarrow version info
--------------------
Package kind              : python-wheel-manylinux2014
Arrow C++ library version : 11.0.0 
Arrow C++ compiler        : GNU 10.2.1
Arrow C++ compiler flags  :  -fdiagnostics-color=always
Arrow C++ git revision    :        
Arrow C++ git description :        
Arrow C++ build type      : release

Happy to help if more information is needed.

Component(s)

Python
@vincent-mercier vincent-mercier changed the title Segmentation fault on compute functions against empty arrays Segmentation fault on unique compute function against empty arrays Feb 17, 2023
@github-actions github-actions bot mentioned this issue Feb 17, 2023
Merged
@westonpace westonpace added Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Component: C++ and removed Component: Python labels Feb 17, 2023
@westonpace westonpace changed the title Segmentation fault on unique compute function against empty arrays [C++] Segmentation fault on unique compute function against empty arrays Feb 17, 2023
westonpace added a commit that referenced this issue Feb 22, 2023
@westonpace
GH-34241: [C++] Fix ExecSpanIterator to properly initialize empty dic…
67fa416 
…tionary arrays (#34246)

* Closes: #34241

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 12.0.0 milestone Feb 22, 2023
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@westonpace @fatemehp
apacheGH-34241: [C++] Fix ExecSpanIterator to properly initialize emp…
cfa4a81 
…ty dictionary arrays (apache#34246)

* Closes: apache#34241

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonpace westonpace

Labels
Component: C++ Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34241: [C++] Fix ExecSpanIterator to properly initialize empty dictionary arrays westonpace/arrow
2 participants
@westonpace @vincent-mercier