-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Future as-of-join-node hangs on distant times #34391
Comments
rtpsw
added a commit
to rtpsw/arrow
that referenced
this issue
Mar 1, 2023
rtpsw
added a commit
to rtpsw/arrow
that referenced
this issue
Apr 9, 2023
rtpsw
added a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
rtpsw
added a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
rtpsw
added a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
pitrou
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 24, 2023
icexelloss
added a commit
that referenced
this issue
Jun 1, 2023
### Rationale for this change To fix a bug in asof join backpresure handling. ### What changes are included in this PR? This is reverting a bug introduced in GH-34391 on this line that breaks asof join backpresure https://github.com/apache/arrow/pull/34392/files#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01eeR1410 ### Are these changes tested? No. However code change simply reverts to the state before the bug was introduced in GH-34391 and therefore should be pretty safe (we have tested that the code before GH-34391 is working). In the meantime @ rtpsw is working on adding tests around this but I would like to merge this to unblock internal issues around this. ### Are there any user-facing changes? * Closes: #35838 Authored-by: Li Jin <ice.xelloss@gmail.com> Signed-off-by: Li Jin <ice.xelloss@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
Future as-of-join-node goes into an infinite loop when right-table times are distant. A specific test case reproducing this is:
Component(s)
C++
The text was updated successfully, but these errors were encountered: