Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Future as-of-join-node hangs on distant times #34391

Closed
rtpsw opened this issue Mar 1, 2023 · 0 comments · Fixed by #34392
Closed

[C++] Future as-of-join-node hangs on distant times #34391

rtpsw opened this issue Mar 1, 2023 · 0 comments · Fixed by #34392
Assignees
Milestone

Comments

@rtpsw
Copy link
Contributor

rtpsw commented Mar 1, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Future as-of-join-node goes into an infinite loop when right-table times are distant. A specific test case reproducing this is:

/*l*/ {R"([[0, 1, 1]])", R"([[1000, 2, 2]])", R"([[2000, 1, 3]])"},
/*r0*/ {R"([[0, 1, 10], [1500, 1, 11], [2500, 1, 12]])"},
/*r1*/ {R"([[0, 1, 100], [1500, 1, 101], [2500, 1, 102]])"},
/*exp_nokey*/ {R"([[0, 0, 1, 10, 100], [1000, 0, 2, 11, 101], [2000, 0, 3, 12, 102]])"},
/*exp_emptykey*/ {R"([[0, 1, 1, 10, 100], [1000, 2, 2, 11, 101], [2000, 1, 3, 12, 102]])"},
/*exp*/ {R"([[0, 1, 1, 10, 100], [1000, 2, 2, null, null], [2000, 1, 3, 12, 102]])"}, 1000);

Component(s)

C++

@rtpsw rtpsw added the Type: bug label Mar 1, 2023
rtpsw added a commit to rtpsw/arrow that referenced this issue Apr 9, 2023
@pitrou pitrou added this to the 13.0.0 milestone May 24, 2023
pitrou added a commit that referenced this issue May 24, 2023
See #34391
* Closes: #34391

Note that the `TestBasic7Forward` test-case included in the PR reproduces the hang in the pre-PR code.

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
icexelloss added a commit that referenced this issue Jun 1, 2023
### Rationale for this change

To fix a bug in asof join backpresure handling.

### What changes are included in this PR?

This is reverting a bug introduced in GH-34391 on this line that breaks asof join backpresure
https://github.com/apache/arrow/pull/34392/files#diff-5493b6ae7ea2a4d5cfb581034c076e9c4be7608382168de6d1301ef67b6c01eeR1410

### Are these changes tested?
No. However code change simply reverts to the state before the bug was introduced in GH-34391 and therefore should be pretty safe (we have tested that the code before GH-34391 is working). In the meantime @ rtpsw is working on adding tests around this but I would like to merge this to unblock internal  issues around this.

### Are there any user-facing changes?

* Closes: #35838

Authored-by: Li Jin <ice.xelloss@gmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants