Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby][FlightRPC] Add ArrowFlight::RecordBatchReader#each #34442

Closed
kou opened this issue Mar 3, 2023 · 0 comments · Fixed by #34444
Closed

[Ruby][FlightRPC] Add ArrowFlight::RecordBatchReader#each #34442

kou opened this issue Mar 3, 2023 · 0 comments · Fixed by #34444
Assignees
@kou
Labels
Component: FlightRPC Component: Ruby Type: enhancement
Milestone
12.0.0

Comments

@kou
Copy link
Member

kou commented Mar 3, 2023

Describe the enhancement requested

All iteratable objects should have #each in Ruby.

Component(s)

FlightRPC, Ruby
@kou kou changed the title [Ruby][FlightRPC] Add ArrowFlight::StreamReader#each [Ruby][FlightRPC] Add ArrowFlight::RecordBatchReader#each Mar 3, 2023
kou added a commit to kou/arrow that referenced this issue Mar 3, 2023
@kou
apacheGH-34442: [Ruby][FlightRPC] Add `ArrowFlight::RecordBatchReader…
0b98093 
…#each`
@github-actions github-actions bot mentioned this issue Mar 3, 2023
Merged
@kou kou closed this as completed in #34444 Mar 4, 2023
kou added a commit that referenced this issue Mar 4, 2023
@kou
GH-34442: [Ruby][FlightRPC] Add ArrowFlight::RecordBatchReader#each (…
f465c34 
…#34444)

### Rationale for this change

Iteratable object should have `#each`.

### What changes are included in this PR?

`#each` and its test.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #34442

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: FlightRPC Component: Ruby Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34442: [Ruby][FlightRPC] Add ArrowFlight::RecordBatchReader#each kou/arrow
1 participant
@kou