Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Failing RecordReaderPrimitveTypeTests #34446

Closed
wjones127 opened this issue Mar 3, 2023 · 0 comments · Fixed by #34447
Closed

[C++] Failing RecordReaderPrimitveTypeTests #34446

wjones127 opened this issue Mar 3, 2023 · 0 comments · Fixed by #34447
Assignees
@wjones127
Labels
Component: C++ Component: Parquet Type: bug
Milestone
12.0.0

Comments

@wjones127
Copy link
Member

wjones127 commented Mar 3, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

See: https://github.com/apache/arrow/actions/runs/4326661366/jobs/7554348864

From collision of #17877 and #34318.

Component(s)

C++, Parquet
@assignUser assignUser mentioned this issue Mar 3, 2023
Merged
@wjones127 wjones127 self-assigned this Mar 3, 2023
@github-actions github-actions bot mentioned this issue Mar 3, 2023
Merged
assignUser pushed a commit that referenced this issue Mar 3, 2023
@wjones127
GH-34446: [C++][Parquet] Fix RecordReaderPrimitveTypeTests test (#34447)
f750649 
### Rationale for this change

The test data was updated in #17877 to have a depth of 3.

An assertion was added concurrently to assert the max depth in #34318.

This PR fixes the test so the changes are compatible.

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #34446

Authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 12.0.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wjones127 wjones127

Labels
Component: C++ Component: Parquet Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34446: [C++][Parquet] Fix RecordReaderPrimitveTypeTests test wjones127/arrow
2 participants
@wjones127 @assignUser