-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Unable to compile R package with GCS on macOS M1 #34523
Comments
Removing Homebrew abseil then re-building from scratch worked. I was then able to reinstall abseil from Homebrew and build w/o |
Ah, this is caused by mixing include paths. |
Interesting @kou, thanks. This is an area I'm not very familiar with but is there a possibility for an improvement to the build system here? |
CMake has some features to control include path order. For example, We may be able to solve this by these features. |
@kou should we reopen this? |
Yes. |
### Rationale for this change If we use a CMake target that provides the same include path for system Abseil in advance of a CMake target for bundled Abseil, header files for system Abseil are used. It causes a link error when system Abseil and bundled Abseil are incompatible. ### What changes are included in this PR? Use a CMake target for bundled Abseil as early as possible. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #34523 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Thanks for the fix @kou ! |
…pache#35387) ### Rationale for this change If we use a CMake target that provides the same include path for system Abseil in advance of a CMake target for bundled Abseil, header files for system Abseil are used. It causes a link error when system Abseil and bundled Abseil are incompatible. ### What changes are included in this PR? Use a CMake target for bundled Abseil as early as possible. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#34523 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…pache#35387) ### Rationale for this change If we use a CMake target that provides the same include path for system Abseil in advance of a CMake target for bundled Abseil, header files for system Abseil are used. It causes a link error when system Abseil and bundled Abseil are incompatible. ### What changes are included in this PR? Use a CMake target for bundled Abseil as early as possible. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#34523 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…pache#35387) ### Rationale for this change If we use a CMake target that provides the same include path for system Abseil in advance of a CMake target for bundled Abseil, header files for system Abseil are used. It causes a link error when system Abseil and bundled Abseil are incompatible. ### What changes are included in this PR? Use a CMake target for bundled Abseil as early as possible. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#34523 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the bug, including details regarding any error messages, version, and platform.
I'm encountering an issue when trying to build the R package from a local build of Arrow C++ but only when I have GCS enabled. The error happens when I run
R CMD INSTALL --preclean --no-multiarch .
:This looked very similar to what was reported in #32487, though I'm not building tests. I first tried setting
CMAKE_CXX_STANDARD=17
which didn't help. @nealrichardson recommendedabsl_SOURCE=BUNDLED
which also didn't help. I do have abseil via Homebrew.I'm including some details of how I'm building everything below. I'm building off of main (2f3f41f):
How I'm building libarrow and the R package
More complete R build output
Component(s)
R
The text was updated successfully, but these errors were encountered: