Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][CSV] Support Binary Types #34572

Closed
yevgenypats opened this issue Mar 15, 2023 · 0 comments · Fixed by #34558
Closed

[Go][CSV] Support Binary Types #34572

yevgenypats opened this issue Mar 15, 2023 · 0 comments · Fixed by #34558
Assignees
@yevgenypats
Labels
Component: Go Type: enhancement
Milestone
12.0.0

Comments

@yevgenypats
Copy link
Contributor

Describe the enhancement requested

Right now CSV package (reader and writer) don't support binary types and return a panic if it's encountered in the schema. We want the reader,write to support it and use the base64 encoding.

Component(s)

Go
@github-actions github-actions bot mentioned this issue Mar 15, 2023
Merged
@kou kou changed the title [GO][CSV] Support Binary Types [Go][CSV] Support Binary Types Mar 15, 2023
zeroshade pushed a commit that referenced this issue Mar 16, 2023
@yevgenypats
GH-34572: [Go][CSV] Add binary support for CSV (#34558)
08e447a 
Adding binary support for CSV
* Closes: #34572

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Mar 16, 2023
rtpsw pushed a commit to rtpsw/arrow that referenced this issue Mar 27, 2023
@yevgenypats @rtpsw
apacheGH-34572: [Go][CSV] Add binary support for CSV (apache#34558)
7bd1c41 
Adding binary support for CSV
* Closes: apache#34572

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yevgenypats yevgenypats

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34572: [Go][CSV] Add binary support for CSV cloudquery/arrow
2 participants
@zeroshade @yevgenypats