Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] test_flight.test_generic_options is consistently failing on AMD64 MacOS Python 3 #34743

Closed
lidavidm opened this issue Mar 27, 2023 · 3 comments · Fixed by #34747
Closed

Comments

@lidavidm
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Observed over several PRs/main

=================================== FAILURES ===================================
_____________________________ test_generic_options _____________________________

    @pytest.mark.requires_testing_data
    def test_generic_options():
        """Test setting generic client options."""
        certs = example_tls_certs()
    
        with ConstantFlightServer(tls_certificates=certs["certificates"]) as s:
            # Try setting a string argument that will make requests fail
            options = [("grpc.ssl_target_name_override", "fakehostname")]
            client = flight.connect(('localhost', s.port),
                                    tls_root_certs=certs["root_cert"],
                                    generic_options=options)
            with pytest.raises(flight.FlightUnavailableError):
                client.do_get(flight.Ticket(b'ints'))
            client.close()
            # Try setting an int argument that will make requests fail
            options = [("grpc.max_receive_message_length", 32)]
            client = flight.connect(('localhost', s.port),
                                    tls_root_certs=certs["root_cert"],
                                    generic_options=options)
            with pytest.raises(pa.ArrowInvalid):
>               client.do_get(flight.Ticket(b'ints'))

/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pyarrow/tests/test_flight.py:2049: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pyarrow/_flight.pyx:1558: in pyarrow._flight.FlightClient.do_get
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   pyarrow._flight.FlightCancelledError: Flight cancelled call, with message: CANCELLED. gRPC client debug context: UNKNOWN:Error received from peer localhost:49538 {grpc_message:"CANCELLED", grpc_status:1, created_time:"2023-03-27T02:01:16.228276+00:00"}. Client context: IOError: Server never sent a data message. Detail: Internal

pyarrow/_flight.pyx:62: FlightCancelledError
----------------------------- Captured stderr call -----------------------------
E0327 02:01:16.198457000 123145459277824 ssl_transport_security.cc:1854] No match found for server name: fakehostname.
E0327 02:01:16.208685000 123145459277824 ssl_transport_security.cc:1854] No match found for server name: fakehostname.

Component(s)

Python

@lidavidm lidavidm changed the title [Python] test_flight.test_generic_options is consistently failing on AMD64 MacOS Python 3` [Python] test_flight.test_generic_options is consistently failing on AMD64 MacOS Python 3 Mar 27, 2023
@lidavidm
Copy link
Member Author

I'm unable to reproduce this on aarch64 macOS, though.

@wjones127
Copy link
Member

@lidavidm I'll take a look on my Intel Mac

@lidavidm
Copy link
Member Author

I put up a PR to just relax the condition already, anyways

wjones127 pushed a commit that referenced this issue Mar 31, 2023
### Rationale for this change
This test is consistently flaky on AMD64 macOS.

### What changes are included in this PR?

Relax the test condition a bit.
### Are these changes tested?

This is a change to a test.

### Are there any user-facing changes?

No.
* Closes: #34743

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
@wjones127 wjones127 added this to the 12.0.0 milestone Mar 31, 2023
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
…#34747)

### Rationale for this change
This test is consistently flaky on AMD64 macOS.

### What changes are included in this PR?

Relax the test condition a bit.
### Are these changes tested?

This is a change to a test.

### Are there any user-facing changes?

No.
* Closes: apache#34743

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants