Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] ZstdCompressionCodec uses hard-coding compression level which cannot be configurable #34749

Closed
viirya opened this issue Mar 27, 2023 · 1 comment · Fixed by #34873
Closed

[Java] ZstdCompressionCodec uses hard-coding compression level which cannot be configurable #34749

viirya opened this issue Mar 27, 2023 · 1 comment · Fixed by #34873
Labels
Component: Java Type: enhancement
Milestone
13.0.0

Comments

@viirya
Copy link
Member

viirya commented Mar 27, 2023

Describe the enhancement requested

ArrowFileWriter/ArrowStreamWriter add compression support for 12.0.0-dev. But ZstdCompressionCodec uses hard-coding compression level (level 3) which cannot be configurable. As ZSTD level affects compression speed and ratio, ideally we should make such parameter configurable to developers.

Component(s)

Java
@davisusanibar davisusanibar mentioned this issue Apr 4, 2023
Merged
davisusanibar added a commit to davisusanibar/arrow that referenced this issue Apr 21, 2023
@davisusanibar
Merge branch 'main' into apacheGH-34749
9ed45e7
davisusanibar added a commit to davisusanibar/arrow that referenced this issue Jun 3, 2023
@davisusanibar
Merge branch 'main' into apacheGH-34749
23d086e
@lidavidm
Copy link
Member

lidavidm commented Jun 5, 2023

@davisusanibar you need to assign yourself here

lidavidm pushed a commit that referenced this issue Jun 5, 2023
@davisusanibar @wgtmac
GH-34749 : [Java] Make Zstd compression level configurable (#34873)
87d0824 
### Rationale for this change

Closes: #34749

### What changes are included in this PR?

Make compression level configurable for Zstd

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #34749

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 13.0.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-34749 : [Java] Make Zstd compression level configurable davisusanibar/arrow
2 participants
@viirya @lidavidm