Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] file.NewParquetReader doesn't properly handle all io.ReaderAt implementations #34807

Closed
agchang opened this issue Mar 30, 2023 · 1 comment · Fixed by #34808
Closed

[Go] file.NewParquetReader doesn't properly handle all io.ReaderAt implementations #34807

agchang opened this issue Mar 30, 2023 · 1 comment · Fixed by #34808
Assignees
@agchang
Labels
Component: Go Type: bug
Milestone
12.0.0

Comments

@agchang
Copy link
Contributor

agchang commented Mar 30, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Specifically, when supplied an implementation of parquet.ReaderSeeker that returns io.EOF as an error when io.ReadAt perfect reads to the end of stream, it interprets it as a proper error:

https://github.com/apache/arrow/blob/go/v11.0.0/go/parquet/file/file_reader.go#L166-L168

The interface of io.ReaderAt states (https://pkg.go.dev/io#ReaderAt):

If the n = len(p) bytes returned by ReadAt are at the end of the input source, ReadAt may return either err == EOF or err == nil.

Component(s)

Go
@agchang
Copy link
Contributor Author

agchang commented Mar 30, 2023

I can submit a patch - the fix is straightforward.

@github-actions github-actions bot mentioned this issue Mar 30, 2023
Merged
zeroshade added a commit that referenced this issue Apr 10, 2023
@agchang @zeroshade
GH-34807: [Go] Handle io.EOF when reading parquet footer size and m…
e50729a 
…agic bytes (#34808)

* Closes: #34807

Lead-authored-by: Andy Chang <achang@arize.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Apr 10, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@agchang @zeroshade @liujiacheng777
apacheGH-34807: [Go] Handle io.EOF when reading parquet footer size…
17b34cf 
… and magic bytes (apache#34808)

* Closes: apache#34807

Lead-authored-by: Andy Chang <achang@arize.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@agchang @zeroshade @ArgusLi
apacheGH-34807: [Go] Handle io.EOF when reading parquet footer size…
44b4113 
… and magic bytes (apache#34808)

* Closes: apache#34807

Lead-authored-by: Andy Chang <achang@arize.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@agchang @zeroshade @rtpsw
apacheGH-34807: [Go] Handle io.EOF when reading parquet footer size…
c803c21 
… and magic bytes (apache#34808)

* Closes: apache#34807

Lead-authored-by: Andy Chang <achang@arize.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agchang agchang

Labels
Component: Go Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34807: [Go] Handle io.EOF when reading parquet footer size and magic bytes agchang/arrow
2 participants
@zeroshade @agchang