Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby] Remove omit("Need to add support for DictionaryArrayBuilder") #34946

Closed
kou opened this issue Apr 7, 2023 · 0 comments · Fixed by #34947
Closed

[Ruby] Remove omit("Need to add support for DictionaryArrayBuilder") #34946

kou opened this issue Apr 7, 2023 · 0 comments · Fixed by #34947
Assignees
@kou
Labels
Component: Ruby Type: enhancement
Milestone
12.0.0

Comments

@kou
Copy link
Member

kou commented Apr 7, 2023

Describe the enhancement requested

Our tests has many omit("Need to add support for DictionaryArrayBuilder") but we can remove them with the existing APIs.

Component(s)

Ruby
kou added a commit to kou/arrow that referenced this issue Apr 7, 2023
@kou
apacheGH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions
4ef38b5
@github-actions github-actions bot mentioned this issue Apr 7, 2023
Merged
@kou kou closed this as completed in #34947 Apr 7, 2023
kou added a commit that referenced this issue Apr 7, 2023
@kou
GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions (#34947
7526df9 
)

### Rationale for this change

We can remove these omissions with the existing APIs.

### What changes are included in this PR?

Implement omitted tests with the existing APIs.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #34946

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Apr 7, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@kou @liujiacheng777
apacheGH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions (
7b5fd4b 
apache#34947)

### Rationale for this change

We can remove these omissions with the existing APIs.

### What changes are included in this PR?

Implement omitted tests with the existing APIs.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#34946

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kou @ArgusLi
apacheGH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions (
d15ff4e 
apache#34947)

### Rationale for this change

We can remove these omissions with the existing APIs.

### What changes are included in this PR?

Implement omitted tests with the existing APIs.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#34946

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@kou @rtpsw
apacheGH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions (
90d316f 
apache#34947)

### Rationale for this change

We can remove these omissions with the existing APIs.

### What changes are included in this PR?

Implement omitted tests with the existing APIs.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#34946

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Ruby Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34946: [Ruby] Remove DictionaryArrayBuilder related omissions kou/arrow
1 participant
@kou