[C++] Valgrind failure with PrintValue for REETestData and PageIndexReaderParam #35008
Assignees
Labels
Milestone
Comments
Merged
1 task
wjones127
added a commit
that referenced
this issue
Apr 13, 2023
… to placate Valgrind (#35011) ### Rationale for this change It seems this is necessary to make Valgrind happy with parameterized GTest cases. See: https://stackoverflow.com/questions/33747056/c-using-gtest-value-parameterized-tests-with-structs-causes-valgrind-errors ### What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ### Are these changes tested? * [x] Run the crossbow job for valgrind ### Are there any user-facing changes? * Closes: #35008 Authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
mikelui
pushed a commit
to mikelui/arrow
that referenced
this issue
Apr 14, 2023
…dexReaderParam to placate Valgrind (apache#35011)" This reverts commit c03ca8f.
raulcd
pushed a commit
that referenced
this issue
Apr 17, 2023
… to placate Valgrind (#35011) ### Rationale for this change It seems this is necessary to make Valgrind happy with parameterized GTest cases. See: https://stackoverflow.com/questions/33747056/c-using-gtest-value-parameterized-tests-with-structs-causes-valgrind-errors ### What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ### Are these changes tested? * [x] Run the crossbow job for valgrind ### Are there any user-facing changes? * Closes: #35008 Authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…rParam to placate Valgrind (apache#35011) ### Rationale for this change It seems this is necessary to make Valgrind happy with parameterized GTest cases. See: https://stackoverflow.com/questions/33747056/c-using-gtest-value-parameterized-tests-with-structs-causes-valgrind-errors ### What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ### Are these changes tested? * [x] Run the crossbow job for valgrind ### Are there any user-facing changes? * Closes: apache#35008 Authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…rParam to placate Valgrind (apache#35011) ### Rationale for this change It seems this is necessary to make Valgrind happy with parameterized GTest cases. See: https://stackoverflow.com/questions/33747056/c-using-gtest-value-parameterized-tests-with-structs-causes-valgrind-errors ### What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ### Are these changes tested? * [x] Run the crossbow job for valgrind ### Are there any user-facing changes? * Closes: apache#35008 Authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…rParam to placate Valgrind (apache#35011) ### Rationale for this change It seems this is necessary to make Valgrind happy with parameterized GTest cases. See: https://stackoverflow.com/questions/33747056/c-using-gtest-value-parameterized-tests-with-structs-causes-valgrind-errors ### What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ### Are these changes tested? * [x] Run the crossbow job for valgrind ### Are there any user-facing changes? * Closes: apache#35008 Authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
I think the fix should be similar to https://github.com/apache/arrow/pull/14317/files
Failure here: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=47089&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=5098
Component(s)
C++
The text was updated successfully, but these errors were encountered: