Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Java] Build C++ libraries macOS x86_64 Failing #35018

Closed
aiguofer opened this issue Apr 10, 2023 · 0 comments · Fixed by #35023
Closed

[CI][Java] Build C++ libraries macOS x86_64 Failing #35018

aiguofer opened this issue Apr 10, 2023 · 0 comments · Fixed by #35023
Assignees
@kou
Labels
Component: Continuous Integration Component: Java Priority: Blocker Marks a blocker for the release Type: bug
Milestone
12.0.0

Comments

@aiguofer
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Crossbow Build C++ libraries macOS x86_64 is failing with:

2023-04-09T08:58:43.6973290Z + archery linking check-dependencies --allow CoreFoundation --allow Security --allow libSystem --allow libarrow_cdata_jni --allow libarrow_dataset_jni --allow libarrow_orc_jni --allow libc++ --allow libcurl --allow libgandiva_jni --allow libncurses --allow libobjc --allow libz libarrow_cdata_jni.dylib libarrow_dataset_jni.dylib libarrow_orc_jni.dylib libgandiva_jni.dylib
2023-04-09T08:58:47.8367910Z Error: Unexpected shared dependency found in libgandiva_jni.dylib: `libzstd`

This is preventing the nightly Java jars from being uploaded: https://nightlies.apache.org/arrow/java/org/apache/arrow/

This issue is mentioned in #34867 (comment) and #34227 (comment)

Component(s)

Continuous Integration
@davisusanibar davisusanibar mentioned this issue Apr 10, 2023
Merged
@kou kou changed the title [CI] Build C++ libraries macOS x86_64 Failing [CI][java] Build C++ libraries macOS x86_64 Failing Apr 11, 2023
@kou kou changed the title [CI][java] Build C++ libraries macOS x86_64 Failing [CI][Java] Build C++ libraries macOS x86_64 Failing Apr 11, 2023
kou added a commit to kou/arrow that referenced this issue Apr 11, 2023
@kou
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
7035e7d 
LLVM may use Zstandard. For example `llvm@15` in Homebrew uses
Zstandard. LLVM finds Zstandared by itself. So libzstd.dylib may be
used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

This change adjusts Zstandared used by LLVM to reflect
`ARROW_ZSTD_USE_SHARED`.
@github-actions github-actions bot mentioned this issue Apr 11, 2023
Merged
@raulcd raulcd added this to the 12.0.0 milestone Apr 11, 2023
@raulcd raulcd added the Priority: Blocker Marks a blocker for the release label Apr 11, 2023
kou added a commit that referenced this issue Apr 12, 2023
@kou
GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (#35023
0434ab6 
)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@kou @liujiacheng777
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (
b62e33f 
apache#35023)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kou @ArgusLi
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (
7d7c1cf 
apache#35023)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@kou @rtpsw
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (
8737445 
apache#35023)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Continuous Integration Component: Java Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM kou/arrow
3 participants
@kou @raulcd @aiguofer