Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] [Datasets] Add support for multi-file datasets from Java #35033

Closed
noahfrn opened this issue Apr 11, 2023 · 1 comment · Fixed by #35034
Closed

[Java] [Datasets] Add support for multi-file datasets from Java #35033

noahfrn opened this issue Apr 11, 2023 · 1 comment · Fixed by #35034

Comments

@noahfrn
Copy link
Contributor

noahfrn commented Apr 11, 2023

Describe the enhancement requested

I'd like to add support for multi-file datasets from Java, without having to keep them in the same directory. This functionality already exists in the C++ libraries, as well as multiple client bindings (Python, R, etc).

Component(s)

Java

@noahfrn
Copy link
Contributor Author

noahfrn commented Apr 11, 2023

take

lidavidm pushed a commit that referenced this issue Jun 2, 2023
…Java (#35034)

I'd like to add support for multi-file datasets (in different directories) in the Java bindings.
This PR adds to the existing Datasets API to allow an array of URIs to be passed in. The logic for whether the URIs passed are valid or not exists in the JNI layer.
* Closes: #35033

Lead-authored-by: NoahFournier <fourniernoah6@gmail.com>
Co-authored-by: NoahFournier <63198198+NoahFournier@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 13.0.0 milestone Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants