Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Go] golang test failures in nightly verification tasks #35062

Closed
assignUser opened this issue Apr 12, 2023 · 0 comments · Fixed by #35077
Closed

[CI][Go] golang test failures in nightly verification tasks #35062

assignUser opened this issue Apr 12, 2023 · 0 comments · Fixed by #35077
Assignees
@zeroshade
Labels
Component: Continuous Integration Component: Go Priority: Blocker Marks a blocker for the release Type: bug
Milestone
12.0.0

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/4667712548/jobs/8263854756#step:7:81

https://github.com/ursacomputing/crossbow/actions/runs/4667721010/jobs/8263873621#step:6:1309

cc @zeroshade

Component(s)

Continuous Integration, Go
@assignUser assignUser added Type: bug Priority: Blocker Marks a blocker for the release labels Apr 12, 2023
@assignUser assignUser added this to the 12.0.0 milestone Apr 12, 2023
@zeroshade zeroshade self-assigned this Apr 12, 2023
zeroshade added a commit to zeroshade/arrow that referenced this issue Apr 12, 2023
@zeroshade
apacheGH-35062: [Go][CI] Fix verification failures
e28442c
@github-actions github-actions bot mentioned this issue Apr 12, 2023
Merged
assignUser pushed a commit that referenced this issue Apr 12, 2023
@zeroshade
GH-35062: [Go][CI] Fix verification failures (#35077)
1912fb9 
### Rationale for this change
In the conda release verification we saw an error failure due to "build constraints exclude all files" in the `memory/mallocator` directory. This is easily fixed by adding a `doc.go` file with a package documentation and no build constraint on it to the directory. While here, to ensure everything is handled correctly, the `cgo` constraint was added to the default `mallocator` tagged files (and `!cgo` to the defaults) so that it's explicit rather than implicit (by virtue of importing mallocator which requires cgo).

This should, hopefully, also fix the other macos verification failure by ensuring the Time64 nanosecond parsing test doesn't just drop the extraneous 0.

### What changes are included in this PR?

### Are there any user-facing changes?
There shouldn't be.

* Closes: #35062

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@zeroshade @liujiacheng777
apacheGH-35062: [Go][CI] Fix verification failures (apache#35077)
da40413 
### Rationale for this change
In the conda release verification we saw an error failure due to "build constraints exclude all files" in the `memory/mallocator` directory. This is easily fixed by adding a `doc.go` file with a package documentation and no build constraint on it to the directory. While here, to ensure everything is handled correctly, the `cgo` constraint was added to the default `mallocator` tagged files (and `!cgo` to the defaults) so that it's explicit rather than implicit (by virtue of importing mallocator which requires cgo).

This should, hopefully, also fix the other macos verification failure by ensuring the Time64 nanosecond parsing test doesn't just drop the extraneous 0.

### What changes are included in this PR?

### Are there any user-facing changes?
There shouldn't be.

* Closes: apache#35062

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@zeroshade @ArgusLi
apacheGH-35062: [Go][CI] Fix verification failures (apache#35077)
d60e748 
### Rationale for this change
In the conda release verification we saw an error failure due to "build constraints exclude all files" in the `memory/mallocator` directory. This is easily fixed by adding a `doc.go` file with a package documentation and no build constraint on it to the directory. While here, to ensure everything is handled correctly, the `cgo` constraint was added to the default `mallocator` tagged files (and `!cgo` to the defaults) so that it's explicit rather than implicit (by virtue of importing mallocator which requires cgo).

This should, hopefully, also fix the other macos verification failure by ensuring the Time64 nanosecond parsing test doesn't just drop the extraneous 0.

### What changes are included in this PR?

### Are there any user-facing changes?
There shouldn't be.

* Closes: apache#35062

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@zeroshade @rtpsw
apacheGH-35062: [Go][CI] Fix verification failures (apache#35077)
474b3e9 
### Rationale for this change
In the conda release verification we saw an error failure due to "build constraints exclude all files" in the `memory/mallocator` directory. This is easily fixed by adding a `doc.go` file with a package documentation and no build constraint on it to the directory. While here, to ensure everything is handled correctly, the `cgo` constraint was added to the default `mallocator` tagged files (and `!cgo` to the defaults) so that it's explicit rather than implicit (by virtue of importing mallocator which requires cgo).

This should, hopefully, also fix the other macos verification failure by ensuring the Time64 nanosecond parsing test doesn't just drop the extraneous 0.

### What changes are included in this PR?

### Are there any user-facing changes?
There shouldn't be.

* Closes: apache#35062

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Continuous Integration Component: Go Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-35062: [Go][CI] Fix verification failures zeroshade/arrow
2 participants
@zeroshade @assignUser