[C++] Update the uses of the LOCATION target property in ArrowConfig.cmake.in #35101
Comments
Crystrix
changed the title
kou
pushed a commit
that referenced
this issue
Apr 14, 2023
…nfig.cmake.in (#35109) ### Rationale for this change Issue: #35101 Application in release mode is linked to the debug version `libarrow_bundled_dependencies.a` if Arrow is installed by vcpkg. As the deprecated `LOCATION` property in `ArrowConfig.cmake.in` always returns the debug lib's path. (https://cmake.org/cmake/help/latest/policy/CMP0026.html) ### What changes are included in this PR? Use `IMPORTED_LOCATION_DEBUG` and `IMPORTED_LOCATION_DEBUG` to replace the deprecated `LOCATION` property in `ArrowConfig.cmake.in`. ### Are these changes tested? It's a fix of vcpkg build. ### Are there any user-facing changes? No * Closes: #35101 Authored-by: Chenxi Li <chenxi.li@live.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…rrowConfig.cmake.in (apache#35109) ### Rationale for this change Issue: apache#35101 Application in release mode is linked to the debug version `libarrow_bundled_dependencies.a` if Arrow is installed by vcpkg. As the deprecated `LOCATION` property in `ArrowConfig.cmake.in` always returns the debug lib's path. (https://cmake.org/cmake/help/latest/policy/CMP0026.html) ### What changes are included in this PR? Use `IMPORTED_LOCATION_DEBUG` and `IMPORTED_LOCATION_DEBUG` to replace the deprecated `LOCATION` property in `ArrowConfig.cmake.in`. ### Are these changes tested? It's a fix of vcpkg build. ### Are there any user-facing changes? No * Closes: apache#35101 Authored-by: Chenxi Li <chenxi.li@live.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…rrowConfig.cmake.in (apache#35109) ### Rationale for this change Issue: apache#35101 Application in release mode is linked to the debug version `libarrow_bundled_dependencies.a` if Arrow is installed by vcpkg. As the deprecated `LOCATION` property in `ArrowConfig.cmake.in` always returns the debug lib's path. (https://cmake.org/cmake/help/latest/policy/CMP0026.html) ### What changes are included in this PR? Use `IMPORTED_LOCATION_DEBUG` and `IMPORTED_LOCATION_DEBUG` to replace the deprecated `LOCATION` property in `ArrowConfig.cmake.in`. ### Are these changes tested? It's a fix of vcpkg build. ### Are there any user-facing changes? No * Closes: apache#35101 Authored-by: Chenxi Li <chenxi.li@live.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…rrowConfig.cmake.in (apache#35109) ### Rationale for this change Issue: apache#35101 Application in release mode is linked to the debug version `libarrow_bundled_dependencies.a` if Arrow is installed by vcpkg. As the deprecated `LOCATION` property in `ArrowConfig.cmake.in` always returns the debug lib's path. (https://cmake.org/cmake/help/latest/policy/CMP0026.html) ### What changes are included in this PR? Use `IMPORTED_LOCATION_DEBUG` and `IMPORTED_LOCATION_DEBUG` to replace the deprecated `LOCATION` property in `ArrowConfig.cmake.in`. ### Are these changes tested? It's a fix of vcpkg build. ### Are there any user-facing changes? No * Closes: apache#35101 Authored-by: Chenxi Li <chenxi.li@live.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
My Arrow was installed using vcpkg and the relevant settings are as follows:
ARROW_JEMALLOC=ONARROW_JEMALLOC_USE_SHARED=OFFI found that my application built in release mode is linked to
debug/lib/libarrow_bundled_dependencies.a. This should be due to an incorrect link path generated by the LOCATION property in ArrowConfig.cmake, and this setting is also outdated (https://cmake.org/cmake/help/latest/policy/CMP0026.html).Component(s)
C++
The text was updated successfully, but these errors were encountered: