Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Flight][C++] Flight build fails on verification job for windows with missing symbol on GRPC/SSL #35206

Closed
raulcd opened this issue Apr 18, 2023 · 6 comments · Fixed by #35225

Comments

@raulcd
Copy link
Member

raulcd commented Apr 18, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The windows verification job has been failing for the last 15 days:

It seems that the issue is with GRPC / SSL:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(1091,5): warning MSB8027: Two or more files with the name of serialization_internal.cc will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are D:\a\crossbow\crossbow\arrow\cpp\src\arrow\flight\serialization_internal.cc, D:\a\crossbow\crossbow\arrow\cpp\src\arrow\flight\transport\grpc\serialization_internal.cc. [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\flight\arrow_flight_shared.vcxproj]
  unity_2_cxx.cxx
  unity_1_cxx.cxx
  unity_0_cxx.cxx
  Flight.pb.cc
     Creating library D:/a/crossbow/crossbow/arrow/cpp/build/release/Release/arrow_flight.lib and object D:/a/crossbow/crossbow/arrow/cpp/build/release/Release/arrow_flight.exp
grpc.lib(json_token.cc.obj) : error LNK2019: unresolved external symbol EVP_DigestSignUpdate referenced in function "char * __cdecl compute_and_encode_signature(struct grpc_auth_json_key const *,char const *,char const *)" (?compute_and_encode_signature@@YAPEADPEBUgrpc_auth_json_key@@PEBD1@Z) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\flight\arrow_flight_shared.vcxproj]
grpc.lib(ssl_transport_security.cc.obj) : error LNK2019: unresolved external symbol SSL_get1_peer_certificate referenced in function "enum tsi_result __cdecl ssl_handshaker_result_extract_peer(struct tsi_handshaker_result const *,struct tsi_peer *)" (?ssl_handshaker_result_extract_peer@@YA?AW4tsi_result@@PEBUtsi_handshaker_result@@PEAUtsi_peer@@@Z) [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\flight\arrow_flight_shared.vcxproj]
D:\a\crossbow\crossbow\arrow\cpp\build\release\Release\arrow_flight.dll : fatal error LNK1120: 2 unresolved externals [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\flight\arrow_flight_shared.vcxproj]

This should be fixed for 12.0.0.

Component(s)

C++, Continuous Integration, FlightRPC

@raulcd
Copy link
Member Author

raulcd commented Apr 18, 2023

@lidavidm any idea on this one?

@lidavidm
Copy link
Member

Hmm, no clue. OpenSSL and gRPC versions look the same between the last success/first failure.

@lidavidm
Copy link
Member

The only dependency changes between the first failure/last success were hypothesis, cython, and cmake (minor version bump) which seem like they should be ok.

@lidavidm
Copy link
Member

Nothing in the diff seems relevant either.

@lidavidm
Copy link
Member

Failure:

-- Found OpenSSL: optimized;C:/Program Files/OpenSSL/lib/VC/libcrypto64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libcrypto64MDd.lib (found suitable version "1.1.1t", minimum required is "1.0.2")  

Success:

-- Found OpenSSL: C:/tmp/arrow-verify-release/conda-env/Library/lib/libcrypto.lib (found suitable version "3.1.0", minimum required is "1.0.2")  

It looks like we're somehow linking against system OpenSSL by accident

@lidavidm
Copy link
Member

trying something in #35225

lidavidm added a commit to lidavidm/arrow that referenced this issue Apr 19, 2023
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
raulcd pushed a commit that referenced this issue Apr 19, 2023
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #35206

Lead-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd pushed a commit that referenced this issue Apr 19, 2023
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #35206

Lead-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
…pache#35225)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35206

Lead-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
…pache#35225)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35206

Lead-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
…pache#35225)

### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35206

Lead-authored-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants