-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Implement MapType #35243
Comments
Yes, sounds like you have it correct. Here is the comment from schema.fbs:
|
### What changes are included in this PR? This change includes the original work by `@ Platob` from #35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes #35243 * Closes: #35243 Lead-authored-by: Platob <nfillot.pro@gmail.com> Co-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: David Li <li.davidm96@gmail.com>
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <nfillot.pro@gmail.com> Co-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: David Li <li.davidm96@gmail.com>
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <nfillot.pro@gmail.com> Co-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: David Li <li.davidm96@gmail.com>
### What changes are included in this PR? This change includes the original work by `@ Platob` from apache#35263, updated with the latest changes in the main branch. Additionally, it includes support in the C API for the Map type and fills a few gaps in functionality from the original change (for instance, ArrowArrayConcentrator support). Finally, it fixes a bug in the ArrowArrayConcentrator.Concatenate which prevented it from working correctly for structs. (This bug was discovered in the course of creating a test for concatenating maps.) ### Are these changes tested? Yes. ### Are there any user-facing changes? Maps are now supported in the C# implementation. Closes apache#35243 * Closes: apache#35243 Lead-authored-by: Platob <nfillot.pro@gmail.com> Co-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Describe the enhancement requested
Hello,
i started dev on new implementation of MapType, im wondering how it should be built ?
I think is a list of Struct which are like
KeyValuePair
c# classComponent(s)
C#
The text was updated successfully, but these errors were encountered: