Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] TotalBytes and TotalRecords not being serialized by C# flight library #35267

Closed
westonpace opened this issue Apr 21, 2023 · 0 comments · Fixed by #35222
Closed

[C#] TotalBytes and TotalRecords not being serialized by C# flight library #35267

westonpace opened this issue Apr 21, 2023 · 0 comments · Fixed by #35222
Labels
Component: C# Type: bug
Milestone
13.0.0

Comments

@westonpace
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

When converting from C# object to proto object the implementation forgot to set these properties.

Component(s)

C#
@github-actions github-actions bot mentioned this issue Apr 21, 2023
Merged
westonpace pushed a commit that referenced this issue May 5, 2023
@jeremyosterhoudt
GH-35267: [C#] Serialize TotalBytes and TotalRecords in FlightInfo (#…
b43f4cd 
…35222)

Currently the `TotalBytes` and `TotalRecords` properties are not serialized into the `FlightInfo` ProtoBuf for C#/.NET.  This breaks compatibility with Arrow Flight implementation done in other languages (c++ for example).

This PR adds the `TotalBytes` and `TotalRecords` properties to the protoBuf `FlightInfo` for the C# implementation.
* Closes: #35267

Authored-by: Jeremy Osterhoudt <jeremy.osterhoudt@ge.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 13.0.0 milestone May 5, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@jeremyosterhoudt @liujiacheng777
apacheGH-35267: [C#] Serialize TotalBytes and TotalRecords in FlightI…
1372980 
…nfo (apache#35222)

Currently the `TotalBytes` and `TotalRecords` properties are not serialized into the `FlightInfo` ProtoBuf for C#/.NET.  This breaks compatibility with Arrow Flight implementation done in other languages (c++ for example).

This PR adds the `TotalBytes` and `TotalRecords` properties to the protoBuf `FlightInfo` for the C# implementation.
* Closes: apache#35267

Authored-by: Jeremy Osterhoudt <jeremy.osterhoudt@ge.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@jeremyosterhoudt @ArgusLi
apacheGH-35267: [C#] Serialize TotalBytes and TotalRecords in FlightI…
b50ce31 
…nfo (apache#35222)

Currently the `TotalBytes` and `TotalRecords` properties are not serialized into the `FlightInfo` ProtoBuf for C#/.NET.  This breaks compatibility with Arrow Flight implementation done in other languages (c++ for example).

This PR adds the `TotalBytes` and `TotalRecords` properties to the protoBuf `FlightInfo` for the C# implementation.
* Closes: apache#35267

Authored-by: Jeremy Osterhoudt <jeremy.osterhoudt@ge.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@jeremyosterhoudt @rtpsw
apacheGH-35267: [C#] Serialize TotalBytes and TotalRecords in FlightI…
25f00fe 
…nfo (apache#35222)

Currently the `TotalBytes` and `TotalRecords` properties are not serialized into the `FlightInfo` ProtoBuf for C#/.NET.  This breaks compatibility with Arrow Flight implementation done in other languages (c++ for example).

This PR adds the `TotalBytes` and `TotalRecords` properties to the protoBuf `FlightInfo` for the C# implementation.
* Closes: apache#35267

Authored-by: Jeremy Osterhoudt <jeremy.osterhoudt@ge.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C# Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35267: [C#] Serialize TotalBytes and TotalRecords in FlightInfo jeremyosterhoudt/arrow
1 participant
@westonpace