Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go]: Schema Fields returns reference instead of copy #35306

Closed
yevgenypats opened this issue Apr 24, 2023 · 0 comments · Fixed by #35307
Closed

[Go]: Schema Fields returns reference instead of copy #35306

yevgenypats opened this issue Apr 24, 2023 · 0 comments · Fixed by #35307
Assignees
@yevgenypats
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@yevgenypats
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

All methods on Schema returns objects that shouldn't mutate the schema itself apart from Fields().

Component(s)

Go
yevgenypats added a commit to cloudquery/arrow that referenced this issue Apr 24, 2023
@yevgenypats
apacheGH-35306: Fix Schema.Fields() to return copy of fields
e6fd621
@github-actions github-actions bot mentioned this issue Apr 24, 2023
Merged
@zeroshade zeroshade added this to the 13.0.0 milestone Apr 25, 2023
zeroshade pushed a commit that referenced this issue Apr 25, 2023
@yevgenypats
GH-35306: Fix Schema.Fields() to return copy of fields (#35307)
9588da9 
* Closes: #35306

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@yevgenypats @liujiacheng777
apacheGH-35306: Fix Schema.Fields() to return copy of fields (apache#…
5758621 
…35307)

* Closes: apache#35306

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@yevgenypats @ArgusLi
apacheGH-35306: Fix Schema.Fields() to return copy of fields (apache#…
e820fbc 
…35307)

* Closes: apache#35306

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@yevgenypats @rtpsw
apacheGH-35306: Fix Schema.Fields() to return copy of fields (apache#…
802674b 
…35307)

* Closes: apache#35306

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yevgenypats yevgenypats

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35306: [Go] Fix Schema.Fields() to return copy of fields cloudquery/arrow
2 participants
@zeroshade @yevgenypats