Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Consolidate some identical pyarrow Table and RecordBatch APIs #35390

Closed
danepitkin opened this issue May 2, 2023 · 0 comments · Fixed by #35396
Closed

[Python] Consolidate some identical pyarrow Table and RecordBatch APIs #35390

danepitkin opened this issue May 2, 2023 · 0 comments · Fixed by #35396
Assignees
@danepitkin
Labels
Component: Python Type: enhancement
Milestone
13.0.0

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

Table and RecordBatch share identical implementations of many APIs. Let's put this in their shared parent class.

Component(s)

Python
danepitkin added a commit to danepitkin/arrow that referenced this issue May 2, 2023
@danepitkin
apacheGH-35390: Consolidate some shared APIs in pyarrow Table/Recordb…
06c9000 
…atch
@github-actions github-actions bot mentioned this issue May 2, 2023
Merged
danepitkin added a commit to danepitkin/arrow that referenced this issue May 10, 2023
@danepitkin
apacheGH-35390: Consolidate some shared APIs in pyarrow Table/Recordb…
bd3ba22 
…atch
AlenkaF pushed a commit that referenced this issue May 11, 2023
@danepitkin
GH-35390: [Python] Consolidate some APIs in Table and RecordBatch (#3…
e5405e7 
…5396)

### Rationale for this change

Table and RecordBatch share many similar/identical APIs. Let's start consolidating them into the parent class. This diff refactors:

`__dataframe__`
`__eq__`
`__getitem__`
`_ensure_integer_index`
`column`
`columns`
`field`
`sort_by`

### Are these changes tested?

Relying on existing test cases for this refactor.

### Are there any user-facing changes?

No
* Closes: #35390

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
@AlenkaF AlenkaF added this to the 13.0.0 milestone May 11, 2023
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@danepitkin @ArgusLi
apacheGH-35390: [Python] Consolidate some APIs in Table and RecordBat…
e840ad8 
…ch (apache#35396)

### Rationale for this change

Table and RecordBatch share many similar/identical APIs. Let's start consolidating them into the parent class. This diff refactors:

`__dataframe__`
`__eq__`
`__getitem__`
`_ensure_integer_index`
`column`
`columns`
`field`
`sort_by`

### Are these changes tested?

Relying on existing test cases for this refactor.

### Are there any user-facing changes?

No
* Closes: apache#35390

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@danepitkin @rtpsw
apacheGH-35390: [Python] Consolidate some APIs in Table and RecordBat…
b69c040 
…ch (apache#35396)

### Rationale for this change

Table and RecordBatch share many similar/identical APIs. Let's start consolidating them into the parent class. This diff refactors:

`__dataframe__`
`__eq__`
`__getitem__`
`_ensure_integer_index`
`column`
`columns`
`field`
`sort_by`

### Are these changes tested?

Relying on existing test cases for this refactor.

### Are there any user-facing changes?

No
* Closes: apache#35390

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Alenka Frim <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35390: [Python] Consolidate some APIs in Table and RecordBatch danepitkin/arrow
2 participants
@AlenkaF @danepitkin