Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Tests failing when comparing a std::vector of floating point values #35571

Closed
felipecrv opened this issue May 12, 2023 · 1 comment · Fixed by #35605
Closed

[C++][Parquet] Tests failing when comparing a std::vector of floating point values #35571

felipecrv opened this issue May 12, 2023 · 1 comment · Fixed by #35605
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
13.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

I saw this in the CI output for Windows AMD64 MINGW builds:

[----------] 6 tests from DecryptionTests/TestDecryptionConfiguration
[ RUN      ] DecryptionTests/TestDecryptionConfiguration.TestDecryption/0
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
[  FAILED  ] DecryptionTests/TestDecryptionConfiguration.TestDecryption/3, where GetParam() = (4, 0xd00c20 pointing to "encrypt_columns_and_footer_aad.parquet.encrypted") (12 ms)
[ RUN      ] DecryptionTests/TestDecryptionConfiguration.TestDecryption/4
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
[  FAILED  ] DecryptionTests/TestDecryptionConfiguration.TestDecryption/4, where GetParam() = (5, 0xd00c54 pointing to "encrypt_columns_and_footer_disable_aad_storage.parquet.encrypted") (4 ms)
[ RUN      ] DecryptionTests/TestDecryptionConfiguration.TestDecryption/5
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
  expected_column_data.values
    Which is: { 0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7, 8.8, 9.9, 11, 12.1, 13.2, 14.3, 15.4, 16.5, 17.6, 18.7, 19.8, 20.9, 22, 23.1, 24.2, 25.3, 26.4, 27.5, 28.6, 29.7, 30.8, 31.9, 33, 34.1, ... }
D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:325: Failure
Expected equality of these values:
  read_col_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
  expected_column_data.values
    Which is: { 0, 1.11111, 2.22222, 3.33333, 4.44444, 5.55556, 6.66667, 7.77778, 8.88889, 10, 11.1111, 12.2222, 13.3333, 14.4444, 15.5556, 16.6667, 17.7778, 18.8889, 20, 21.1111, 22.2222, 23.3333, 24.4444, 25.5556, 26.6667, 27.7778, 28.8889, 30, 31.1111, 32.2222, 33.3333, 34.4444, ... }
[  FAILED  ] DecryptionTests/TestDecryptionConfiguration.TestDecryption/5, where GetParam() = (6, 0xd00c98 pointing to "encrypt_columns_and_footer_ctr.parquet.encrypted") (7 ms)
[----------] 6 tests from DecryptionTests/TestDecryptionConfiguration (71 ms total)

I don't have a Windows machine, but I have an idea for a fix that I'm trying to pass through CI.

Component(s)

C++
@felipecrv felipecrv mentioned this issue May 12, 2023
Merged
@felipecrv felipecrv removed their assignment May 12, 2023
@felipecrv
Copy link
Contributor Author

felipecrv commented May 12, 2023 •
edited
Loading

I attempted a fix that didn't work:

Commit: 6666459
Failed CI job: https://github.com/apache/arrow/actions/runs/4961174385/jobs/8877637080?pr=35422

D:/a/arrow/arrow/cpp/src/parquet/encryption/test_encryption_util.cc:328: Failure
Expected equality of these values:
  memcmp(read_col_data.values.data(), expected_column_data.values.data(), read_col_data.values.size() * sizeof(typename DType::c_type))
    Which is: 1
  0

cc @mapleFU

@github-actions github-actions bot mentioned this issue May 16, 2023
Merged
@mapleFU mapleFU mentioned this issue May 16, 2023
Closed
pitrou added a commit that referenced this issue May 17, 2023
@mapleFU @pitrou
GH-35571: [C++][CI][Parquet] Change EQ to FLOAT_EQ in Decryption …
37975d5 
…tests (#35605)

### Rationale for this change

CI would failed in Decrypt test in Windows MinGW. This is because in some MinGW version, it may generate
truncated stream test data in `GenerateSampleData<FloatType>`, as a fixing, here using `EXPECT_FLOAT_EQ`
to handle that problem

### What changes are included in this PR?

Change comparing float with `_EQ` to `FLOAT_EQ` and `DOUBLE_EQ` in unittest.

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: #35571

Lead-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 13.0.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35571: [C++][CI][Parquet] Change EQ to FLOAT_EQ in Decryption tests mapleFU/arrow
2 participants
@felipecrv @pitrou