[C#] Update Flatbuffers definitions in the C# code #35698
Comments
raulcd
changed the title
westonpace
pushed a commit
that referenced
this issue
Aug 16, 2023
### Rationale for this change The FlatBuffers definitions in the C# code don't seem to have been updated for a while. Adding the latest FlatBuffers code ensures that we're up to date with both the Arrow definitions and the FlatBuffers compiler. ### What changes are included in this PR? The latest version of the C# FlatBuffers runtime files were copied into the project (with visibility changed from public to internal). The latest version of the FlatBuffers compiler was used against the latest version of the Arrow .fbs source. The output of the compiler was edited to more closely match the existing code by moving it into the directory structure and namespaces of the existing classes and by changing class visibility from public to internal. A few small changes were made to the existing source to accommodate changes in the FlatBuffers runtime, most specifically that the files have moved from the namespace "FlatBuffers" to the namespace "Google.FlatBuffers". ### Are these changes tested? No substantive product changes were made. All tests still pass. ### Are there any user-facing changes? No. Resolves #35698 * Closes: #35698 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
### Rationale for this change The FlatBuffers definitions in the C# code don't seem to have been updated for a while. Adding the latest FlatBuffers code ensures that we're up to date with both the Arrow definitions and the FlatBuffers compiler. ### What changes are included in this PR? The latest version of the C# FlatBuffers runtime files were copied into the project (with visibility changed from public to internal). The latest version of the FlatBuffers compiler was used against the latest version of the Arrow .fbs source. The output of the compiler was edited to more closely match the existing code by moving it into the directory structure and namespaces of the existing classes and by changing class visibility from public to internal. A few small changes were made to the existing source to accommodate changes in the FlatBuffers runtime, most specifically that the files have moved from the namespace "FlatBuffers" to the namespace "Google.FlatBuffers". ### Are these changes tested? No substantive product changes were made. All tests still pass. ### Are there any user-facing changes? No. Resolves apache#35698 * Closes: apache#35698 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Update the flatbuffers definitions in the C# code based on both the latest Flatbuffers implementation and on the latest Arrow definitions.
Component(s)
C#
The text was updated successfully, but these errors were encountered: