Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Bump vendored xxhash version #35847

Closed
pitrou opened this issue May 31, 2023 · 2 comments · Fixed by #35849
Closed

[C++] Bump vendored xxhash version #35847

pitrou opened this issue May 31, 2023 · 2 comments · Fixed by #35849
Assignees
@mapleFU
Labels
Component: C++ good-first-issue Type: enhancement
Milestone
13.0.0

Comments

@pitrou
Copy link
Member

pitrou commented May 31, 2023

Describe the enhancement requested

The latest xxhash release may have slight performance improvements.

Component(s)

C++
@pitrou
Copy link
Member Author

pitrou commented May 31, 2023

@mapleFU This might increase bloom filter perf on small entries (or might not :-)).

@mapleFU
Copy link
Member

mapleFU commented May 31, 2023

Seems that we're using xxhash 0.8.0, the new release is v0.8.1: https://github.com/Cyan4973/xxHash/releases/tag/v0.8.1
It improve the performance under gcc and msvc. Clang didn't get enhanced too much

@github-actions github-actions bot mentioned this issue May 31, 2023
Merged
@pitrou pitrou added this to the 13.0.0 milestone Jun 1, 2023
pitrou pushed a commit that referenced this issue Jun 1, 2023
@mapleFU
GH-35847:[C++][Thirdparty] Bump xxhash version to v0.8.1 (#35849)
c1359c5 
### Rationale for this change

Bump xxhash from v.0.8.0 to v0.8.1

### What changes are included in this PR?

Bump xxhash from v.0.8.0 to v0.8.1

### Are these changes tested?

Already has test

### Are there any user-facing changes?

no

* Closes: #35847

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ good-first-issue Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35847:[C++][Thirdparty] Bump xxhash version to v0.8.1 mapleFU/arrow
2 participants
@pitrou @mapleFU