Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Compute] Can we support or in Expression::IsSatisfiable #36423

Closed
mapleFU opened this issue Jul 1, 2023 · 0 comments · Fixed by #36424
Closed

[C++][Compute] Can we support or in Expression::IsSatisfiable #36423

mapleFU opened this issue Jul 1, 2023 · 0 comments · Fixed by #36424
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Jul 1, 2023

Describe the enhancement requested

When I go through the code, I found Expression::IsSatisfiable has handled case for "and" and "and_kleene" function, but "or" and "or_kleene" is not support.
If it's possible, I'd like to submit the code and testing for it

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jul 1, 2023
Merged
pitrou added a commit that referenced this issue Jul 6, 2023
@mapleFU @pitrou
GH-36423: [C++][Compute] Support "or" in Expression::IsSatisfiable (#…
f922e60 
…36424)

### Rationale for this change

This patch supports "or" in `Expression::IsSatisfiable`, if all it child is not satisfiable, the expression itself is not satisfiable.

### What changes are included in this PR?

Support "or" and "or_kleene" in `IsSatisfiable`

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

* Closes: #36423

Lead-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 13.0.0 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36423: [C++][Compute] Support "or" in Expression::IsSatisfiable mapleFU/arrow
2 participants
@pitrou @mapleFU