Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE #36511

Closed
lidavidm opened this issue Jul 6, 2023 · 0 comments · Fixed by #36679
Closed

[C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE #36511

lidavidm opened this issue Jul 6, 2023 · 0 comments · Fixed by #36679
Assignees
@lidavidm
Labels
Component: C++ Component: FlightRPC Type: enhancement
Milestone
14.0.0

Comments

@lidavidm
Copy link
Member

lidavidm commented Jul 6, 2023

Describe the enhancement requested

This was done to support old versions of gRPC that used grpc++ instead of grpcpp for their include directory. But gRPC has supported grpcpp since version 1.10, 2018, which we likely can't even build with anyways: https://github.com/grpc/grpc/tree/v1.10.0/include

And new APIs aren't in the grpc++ directory. So instead of having useless defines, let's just get rid of this branch.

Component(s)

C++, FlightRPC
@lidavidm lidavidm self-assigned this Jul 6, 2023
kou added a commit to kou/arrow that referenced this issue Jul 14, 2023
@kou
apacheGH-36511: [C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE
049df0b 
It's for gRPC < 1.10 and we require gRPC >= 1.30.0. So we can get rid
of it.
@github-actions github-actions bot mentioned this issue Jul 14, 2023
Merged
kou added a commit that referenced this issue Jul 14, 2023
@kou
GH-36511: [C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE (#36679)
601e3c6 
### Rationale for this change

It's for gRPC < 1.10 and we require gRPC >= 1.30.0. So we can get rid of it.

### What changes are included in this PR?

Get rid of GRPCPP_PP_INCLUDE.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #36511

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Jul 14, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@kou @chelseajonesr
apacheGH-36511: [C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE (apache…
9ee4488 
…#36679)

### Rationale for this change

It's for gRPC < 1.10 and we require gRPC >= 1.30.0. So we can get rid of it.

### What changes are included in this PR?

Get rid of GRPCPP_PP_INCLUDE.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36511

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@kou @R-JunmingChen
apacheGH-36511: [C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE (apache…
7152a22 
…#36679)

### Rationale for this change

It's for gRPC < 1.10 and we require gRPC >= 1.30.0. So we can get rid of it.

### What changes are included in this PR?

Get rid of GRPCPP_PP_INCLUDE.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36511

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: C++ Component: FlightRPC Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36511: [C++][FlightRPC] Get rid of GRPCPP_PP_INCLUDE kou/arrow
2 participants
@kou @lidavidm