Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Use C++17's nested namespaces #36643

Closed
Tracked by #36620
mapleFU opened this issue Jul 12, 2023 · 0 comments · Fixed by #36647
Closed
Tracked by #36620

[C++][Parquet] Use C++17's nested namespaces #36643

mapleFU opened this issue Jul 12, 2023 · 0 comments · Fixed by #36647
Assignees
@mapleFU
Labels
Component: C++ Component: Parquet good-first-issue Type: enhancement
Milestone
14.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Jul 12, 2023

Describe the enhancement requested

Part of #36620

Before:

namespace parquet {
namespace arrow {

After:

namespace parquet::arrow {

I guess most of these is under parquet/arrow directory.

Component(s)

C++, Parquet
@github-actions github-actions bot mentioned this issue Jul 12, 2023
Merged
@kou kou mentioned this issue Jul 12, 2023
Open
2 tasks
@pitrou pitrou added this to the 14.0.0 milestone Jul 13, 2023
pitrou pushed a commit that referenced this issue Jul 13, 2023
@mapleFU
GH-36643: [C++][Parquet] Use nested namespace in parquet (#36647)
c9fbc88 
### Rationale for this change

Just for code style, using nested namespace rather than before

### What changes are included in this PR?

Using nested namespace

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: #36643

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@mapleFU @chelseajonesr
apacheGH-36643: [C++][Parquet] Use nested namespace in parquet (apach…
9fa0722 
…e#36647)

### Rationale for this change

Just for code style, using nested namespace rather than before

### What changes are included in this PR?

Using nested namespace

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: apache#36643

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@mapleFU @R-JunmingChen
apacheGH-36643: [C++][Parquet] Use nested namespace in parquet (apach…
cc7c76b 
…e#36647)

### Rationale for this change

Just for code style, using nested namespace rather than before

### What changes are included in this PR?

Using nested namespace

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: apache#36643

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@kou kou mentioned this issue Sep 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Parquet good-first-issue Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36643: [C++][Parquet] Use nested namespace in parquet mapleFU/arrow
2 participants
@pitrou @mapleFU