[Go][Parquet] Add a TimestampLogicalType creation function with all options #36698
Comments
wolfeidau
added a commit
to wolfeidau/arrow
that referenced
this issue
Jul 15, 2023
…ction with more options This change introduces a more flexible creation function for TimestampLogicalType which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. Following on from other great examples in arrow it uses the functional options pattern.
wolfeidau
added a commit
to wolfeidau/arrow
that referenced
this issue
Jul 15, 2023
…ction with more options This change introduces a more flexible creation function for TimestampLogicalType which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. Following on from other great examples in arrow it uses the functional options pattern.
zeroshade
pushed a commit
that referenced
this issue
Jul 20, 2023
#36699) …with more options This change introduces a more flexible creation function for TimestampLogicalType which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. Following on from other great examples in arrow it uses the functional options pattern. ### Rationale for this change Add a `TimestampLogicalType` creation function with more options, in particular an option to set `fromConverted` as I can't see another way to set this private struct property after creation. ### What changes are included in this PR? This change introduces a more flexible creation function for `TimestampLogicalType` which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. ### Are these changes tested? Yes I have updated one of the existing tests. ### Are there any user-facing changes? * Closes: #36698 Authored-by: Mark Wolfe <mark@wolfe.id.au> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this issue
Jul 20, 2023
…ction … (apache#36699) …with more options This change introduces a more flexible creation function for TimestampLogicalType which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. Following on from other great examples in arrow it uses the functional options pattern. ### Rationale for this change Add a `TimestampLogicalType` creation function with more options, in particular an option to set `fromConverted` as I can't see another way to set this private struct property after creation. ### What changes are included in this PR? This change introduces a more flexible creation function for `TimestampLogicalType` which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. ### Are these changes tested? Yes I have updated one of the existing tests. ### Are there any user-facing changes? * Closes: apache#36698 Authored-by: Mark Wolfe <mark@wolfe.id.au> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this issue
Aug 20, 2023
…ction … (apache#36699) …with more options This change introduces a more flexible creation function for TimestampLogicalType which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. Following on from other great examples in arrow it uses the functional options pattern. ### Rationale for this change Add a `TimestampLogicalType` creation function with more options, in particular an option to set `fromConverted` as I can't see another way to set this private struct property after creation. ### What changes are included in this PR? This change introduces a more flexible creation function for `TimestampLogicalType` which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. ### Are these changes tested? Yes I have updated one of the existing tests. ### Are there any user-facing changes? * Closes: apache#36698 Authored-by: Mark Wolfe <mark@wolfe.id.au> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…ction … (apache#36699) …with more options This change introduces a more flexible creation function for TimestampLogicalType which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. Following on from other great examples in arrow it uses the functional options pattern. ### Rationale for this change Add a `TimestampLogicalType` creation function with more options, in particular an option to set `fromConverted` as I can't see another way to set this private struct property after creation. ### What changes are included in this PR? This change introduces a more flexible creation function for `TimestampLogicalType` which will enable changes to all the flags provided by this type, but without requiring a lot of parameters. ### Are these changes tested? Yes I have updated one of the existing tests. ### Are there any user-facing changes? * Closes: apache#36698 Authored-by: Mark Wolfe <mark@wolfe.id.au> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
I am trying to create a timestamp with the
fromConvertedflag enabled, however there is no way to provide this with the existing methods.It would be great to have a more flexible creation function for this type as it has quite a few options.
Component(s)
Go
The text was updated successfully, but these errors were encountered: